Unstable - Run modules-update on internal releases lacking redis-full - #542
Merged
Merged
Conversation
Internal-release tarballs may not bundle redis-full module sources, but the modules-update fallback was gated entirely behind custom_build, so internal releases (built with custom_build=false) never cloned them. Add an `internal` template flag: keep yq version-pinning custom-only, but run the .prepared-gated modules-update for custom OR internal builds. Internal releases re-render with `-s internal true` at build time, so the committed official Dockerfile (custom_build=false, internal=false) stays clean and byte-identical to HEAD. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Peter-Sh
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal-release tarballs may not bundle redis-full module sources, but the modules-update fallback was gated entirely behind custom_build, so internal releases (built with custom_build=false) never cloned them.
Add an
internaltemplate flag: keep yq version-pinning custom-only, but run the .prepared-gated modules-update for custom OR internal builds. Internal releases re-render with-s internal trueat build time, so the committed official Dockerfile (custom_build=false, internal=false) stays clean and byte-identical to HEAD.Note
Medium Risk
Changes release Docker build logic for internal tarballs; mis-gating could skip or over-run
modules-update, but scope is CI/templates only and public release artifacts stay unchanged in git.Overview
Internal release builds can ship Redis tarballs that omit bundled redis-full module sources, but the
modules-updatefallback lived only undercustom_build, so those releases never cloned module sources and could fail module builds.This PR adds an
internalJinja flag (wired throughDockerfileContextandrelease_typeonbuild-n-test/build-and-tag-locally/release_build_and_test). yq module ref pinning stays custom-only;make modules-updatenow runs for custom or internal builds when.preparedsources are missing (custom still re-clones when version overrides are set). Forrun_type=releaseandrelease_type=internal, CI re-renders Dockerfiles at build time with./bin/render-all-dockerfiles.sh -s internal true, so the committed official Dockerfiles remaininternal=falseand stay in sync with validation.Reviewed by Cursor Bugbot for commit 9967bb2. Bugbot is set up for automated code reviews on this repo. Configure here.