Skip to content

release/8.10 Move modules-update to custom build and gate redis_repo - #541

Merged
dariaguy merged 1 commit into
release/8.10from
dariaguy-unstable-custom-fixes
Jul 14, 2026
Merged

release/8.10 Move modules-update to custom build and gate redis_repo#541
dariaguy merged 1 commit into
release/8.10from
dariaguy-unstable-custom-fixes

Conversation

@dariaguy

@dariaguy dariaguy commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Changes affect how release images fetch module sources and enforce release source repo policy; misconfiguration could break custom module builds or block legitimate release dispatches.

Overview
Release workflow now rejects run_type=release when redis_repo is not redis/redis, so official release builds cannot pull Redis from a fork (forks remain allowed for custom/unstable/nightly runs).

Standard release Docker images (committed alpine/debian Dockerfiles) no longer run the bundled modules-update / .prepared skip logic during module builds—they go straight to Rust install and make deploy.

Custom builds (via Dockerfile.j2 with custom_build) still pin module refs with yq, optionally skip modules-update when bundled .prepared sources exist and no module version overrides were passed, and otherwise run modules-update; that whole block is now wrapped entirely inside the custom_build template branch.

Reviewed by Cursor Bugbot for commit 54eecdd. Bugbot is set up for automated code reviews on this repo. Configure here.

@dariaguy dariaguy changed the title Move modules-update to custom build and gate redis_repo release/8.10 Move modules-update to custom build and gate redis_repo Jul 14, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 54eecdd. Configure here.

Comment thread alpine/Dockerfile.j2
@dariaguy
dariaguy merged commit 217b938 into release/8.10 Jul 14, 2026
31 of 47 checks passed
@dariaguy
dariaguy deleted the dariaguy-unstable-custom-fixes branch July 14, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant