release/8.10 Move modules-update to custom build and gate redis_repo - #541
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 54eecdd. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes affect how release images fetch module sources and enforce release source repo policy; misconfiguration could break custom module builds or block legitimate release dispatches.
Overview
Release workflow now rejects
run_type=releasewhenredis_repois notredis/redis, so official release builds cannot pull Redis from a fork (forks remain allowed for custom/unstable/nightly runs).Standard release Docker images (committed
alpine/debianDockerfiles) no longer run the bundledmodules-update/.preparedskip logic during module builds—they go straight to Rust install andmake deploy.Custom builds (via
Dockerfile.j2withcustom_build) still pin module refs withyq, optionally skipmodules-updatewhen bundled.preparedsources exist and no module version overrides were passed, and otherwise runmodules-update; that whole block is now wrapped entirely inside thecustom_buildtemplate branch.Reviewed by Cursor Bugbot for commit 54eecdd. Bugbot is set up for automated code reviews on this repo. Configure here.