Install yq only when build is custom - #539
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Build-dependency conditioning only; custom builds still get
yq, and standard release builds never invoked the yaml-patching path.Overview
yqis no longer installed for standard release/module Docker builds—only when Dockerfiles are rendered withcustom_buildenabled.In
alpine/Dockerfile.j2anddebian/Dockerfile.j2,yq-go/yqare wrapped in{% if custom_build %}inside the module build-deps block, matching the existing custom-build-only step that editsmodules.yamlfromREDISEARCH_VERSIONand related build args. The checked-inalpine/Dockerfileanddebian/Dockerfileare regenerated without those packages (default render usescustom_build=false).Reviewed by Cursor Bugbot for commit cbf2c21. Bugbot is set up for automated code reviews on this repo. Configure here.