Skip to content

Allow Redis buildsystem to recognize and link against libsystemd - #524

Merged
Peter-Sh merged 1 commit into
unstablefrom
systemd_sd_notify_support
Jun 5, 2026
Merged

Allow Redis buildsystem to recognize and link against libsystemd#524
Peter-Sh merged 1 commit into
unstablefrom
systemd_sd_notify_support

Conversation

@Peter-Sh

@Peter-Sh Peter-Sh commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

libsystemd0 already exists in trixie base image
linking agaings libsystemd.so end enabling systemd support in Redis doesn't change its behaviour when systemd socket is not available

This allows Redis buildsystem to enable BUILD_WITH_SYSTEMD automatically by detecting according package.
Simple test is added to ensure redis is linked to libsystemd.so if it exists in the base image

For #373


Note

Low Risk
Build-time dependency and regression-test changes only; no runtime behavior change when systemd sockets are absent.

Overview
Debian image builds now install libsystemd-dev and pkg-config during compile so Redis can auto-enable systemd integration (e.g. sd_notify) when the upstream build detects the library. The same dependency list is mirrored in debian/Dockerfile.j2.

A new entrypoint test test_redis_server_is_linked_against_libsystemd runs only when the runtime image actually ships libsystemd.so; it uses ldd on redis-server and skips on bases like Alpine that do not include systemd.

Reviewed by Cursor Bugbot for commit a38dcaa. Bugbot is set up for automated code reviews on this repo. Configure here.

libsystemd0 already exists in trixie base image
linking agaings libsystemd.so end enabling systemd support in Redis
doesn't change its behaviour when systemd socket is not available

This allows Redis buildsystem to enable BUILD_WITH_SYSTEMD automatically
by detecting according package.
Simple test is added to ensure redis is linked to libsystemd.so if it
exists in the base image

For #373
@jit-ci

jit-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a38dcaa. Configure here.

Comment thread test/run-entrypoint-tests.sh
@Peter-Sh
Peter-Sh merged commit d696021 into unstable Jun 5, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants