Remove backports target release - #522
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
| libtool \ | ||
| g++; \ | ||
| apt-get install -y --no-install-recommends -t trixie-backports clang-21 lld-21 llvm-21; \ | ||
| apt-get install -y --no-install-recommends clang-21 lld-21 llvm-21; \ |
There was a problem hiding this comment.
Backports repository setup is now dead code
Low Severity
The backports repository is still being added on line 42 (echo 'deb ... trixie-backports main' > /etc/apt/sources.list.d/backports.list) and removed on line 61, but no apt-get install command targets it anymore after removing -t trixie-backports. This is now dead code that adds an unnecessary network fetch during apt-get update and could cause unexpected dependency resolution from backports.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit a4c1af6. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 759c1a2. Configure here.
| libtool \ | ||
| g++; \ | ||
| apt-get install -y --no-install-recommends -t trixie-backports clang-21 lld-21 llvm-21; \ | ||
| apt-get install -y --no-install-recommends clang-21 lld-21 llvm-21; \ |
There was a problem hiding this comment.
Removing -t flag breaks backports dependency resolution
Medium Severity
Removing -t trixie-backports from the apt-get install for clang-21 lld-21 llvm-21 while the backports source is still being added suggests these packages still come from backports. According to official Debian documentation, the -t flag is required when a package's dependencies also need to be resolved from backports. Without it, backports packages remain at priority 100 and apt may fail to resolve transitive dependencies that only exist in backports, leading to potential build failures.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 759c1a2. Configure here.


Note
Medium Risk
Adjusts Debian image build dependencies by no longer pinning
clang-21/lld-21/llvm-21totrixie-backports, which could break builds if those versions aren’t available in the default apt sources. Otherwise changes are small and localized to Docker build tooling.Overview
Removes the
-t trixie-backportstarget release when installingclang-21/lld-21/llvm-21in the Debian Docker build, both indebian/Dockerfileand thedebian/Dockerfile.j2template.Also tweaks the
apply-docker-version.shcomment to clarify that the TAG comes from the first positional argument.Reviewed by Cursor Bugbot for commit 759c1a2. Bugbot is set up for automated code reviews on this repo. Configure here.