Skip to content

Remove backports target release - #522

Merged
Peter-Sh merged 2 commits into
unstablefrom
angelyanev-remove-backports-target-release
May 15, 2026
Merged

Remove backports target release#522
Peter-Sh merged 2 commits into
unstablefrom
angelyanev-remove-backports-target-release

Conversation

@AngelYanev

@AngelYanev AngelYanev commented May 15, 2026

Copy link
Copy Markdown

Note

Medium Risk
Adjusts Debian image build dependencies by no longer pinning clang-21/lld-21/llvm-21 to trixie-backports, which could break builds if those versions aren’t available in the default apt sources. Otherwise changes are small and localized to Docker build tooling.

Overview
Removes the -t trixie-backports target release when installing clang-21/lld-21/llvm-21 in the Debian Docker build, both in debian/Dockerfile and the debian/Dockerfile.j2 template.

Also tweaks the apply-docker-version.sh comment to clarify that the TAG comes from the first positional argument.

Reviewed by Cursor Bugbot for commit 759c1a2. Bugbot is set up for automated code reviews on this repo. Configure here.

@jit-ci

jit-ci Bot commented May 15, 2026

Copy link
Copy Markdown

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

Comment thread debian/Dockerfile
libtool \
g++; \
apt-get install -y --no-install-recommends -t trixie-backports clang-21 lld-21 llvm-21; \
apt-get install -y --no-install-recommends clang-21 lld-21 llvm-21; \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backports repository setup is now dead code

Low Severity

The backports repository is still being added on line 42 (echo 'deb ... trixie-backports main' > /etc/apt/sources.list.d/backports.list) and removed on line 61, but no apt-get install command targets it anymore after removing -t trixie-backports. This is now dead code that adds an unnecessary network fetch during apt-get update and could cause unexpected dependency resolution from backports.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a4c1af6. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 759c1a2. Configure here.

Comment thread debian/Dockerfile
libtool \
g++; \
apt-get install -y --no-install-recommends -t trixie-backports clang-21 lld-21 llvm-21; \
apt-get install -y --no-install-recommends clang-21 lld-21 llvm-21; \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing -t flag breaks backports dependency resolution

Medium Severity

Removing -t trixie-backports from the apt-get install for clang-21 lld-21 llvm-21 while the backports source is still being added suggests these packages still come from backports. According to official Debian documentation, the -t flag is required when a package's dependencies also need to be resolved from backports. Without it, backports packages remain at priority 100 and apt may fail to resolve transitive dependencies that only exist in backports, leading to potential build failures.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 759c1a2. Configure here.

@Peter-Sh
Peter-Sh merged commit 40b0091 into unstable May 15, 2026
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants