CWFHEALTH-5089: Fix IndexError in _get_impacted_bundles when bundle has no brew image - #307
Merged
Merged
Conversation
Contributor
Author
|
Related to CWFHEALTH-5008 |
Contributor
Author
FernandesMF
previously approved these changes
Jul 23, 2026
FernandesMF
left a comment
FernandesMF
left a comment
Contributor
There was a problem hiding this comment.
Makes sense and looks good to me!
lslebodn
marked this pull request as draft
July 24, 2026 11:05
get_images_by_digest can return an empty list when a bundle path
digest has no brew-built data in pyxis (e.g. Konflux-built bundles).
We need to skip these instead of crashing with an IndexError on bundle_images[0].
We cannot rebuilt operator bundles which were not built in brew.
Traceback:
File "freshmaker/handlers/botas/botas_shipped_advisory.py", line 372,
in _get_impacted_bundles
bundle_nvr = bundle_images[0]["brew"]["build"]
IndexError: list index out of range
Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
lslebodn
force-pushed
the
bundle_search
branch
from
August 12, 2026 12:11
e917f3b to
48a7799
Compare
lslebodn
changed the title
lslebodn
marked this pull request as ready for review
August 12, 2026 12:12
Contributor
Author
|
Rebased && modified |
lslebodn
changed the title
FernandesMF
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_images_by_digest can return an empty list when a bundle path
digest has no brew-built data in pyxis (e.g. Konflux-built bundles).
We need to skip these instead of crashing with an IndexError on bundle_images[0].
We cannot rebuilt operator bundles which were not built in brew.
Assisted-by: Claude Opus 4.6 noreply@anthropic.com