docs(#3552): add mode-dependent configure() options guidance - #3553
docs(#3552): add mode-dependent configure() options guidance#3553fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add a new Mode-Dependent configure() Options subsection to the E2E Testing section of AGENTS.md, placed after the Plugin Metadata Resolution table. Documents two configure() options with mode-dependent behavior: - disablePlugins: only effective in PR and local dev modes where auto-generation runs; silently ignored in nightly mode. Advises against unnecessary conditional guards since the option is already a no-op in nightly mode. - dynamicPlugins: has destructive side effects in nightly mode (generates disabled:true for baked-in plugins). Documents when a mode guard is needed vs not. Cross-references #3112 for baked-in plugin guidance. Includes review guidance for agents to flag unnecessary mode guards around disablePlugins and missing mode guards around dynamicPlugins. Closes #3552
|
Hi @fullsend-ai-coder[bot]. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
🤖 Finished Review · ✅ Success · Started 3:27 PM UTC · Completed 3:44 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $4.52 |
ReviewFindingsMedium
Low
Labels: PR modifies only AGENTS.md documentation outside workspace directories. |



Add a new Mode-Dependent configure() Options subsection to the E2E Testing section of AGENTS.md, placed after the Plugin Metadata Resolution table.
Documents two configure() options with mode-dependent behavior:
disablePlugins: only effective in PR and local dev modes where
auto-generation runs; silently ignored in nightly mode. Advises
against unnecessary conditional guards since the option is
already a no-op in nightly mode.
dynamicPlugins: has destructive side effects in nightly mode
(generates disabled:true for baked-in plugins). Documents when
a mode guard is needed vs not. Cross-references Add AGENTS.md guidance for baked-in plugin E2E test configuration #3112 for
baked-in plugin guidance.
Includes review guidance for agents to flag unnecessary mode guards around disablePlugins and missing mode guards around dynamicPlugins.
Closes #3552
Post-script verification
agent/3552-configure-mode-guidance)de1e7b92a96b94cc158cb2e943995ebbe1adde18..HEAD)