docs(#3534): add review guidance for dynamic-plugins.yaml minimality

[fullsend-ai-coder]

Add a "Reviewing dynamic-plugins.yaml Changes" subsection to the E2E Testing section of AGENTS.md, after "Configuration Files". This gives the review agent explicit criteria to flag unnecessary entries in dynamic-plugins.yaml files:

• Entries setting disabled: true for plugins outside the workspace
  own metadata (redundant, auto-generation only includes workspace
  plugins)
• Entries duplicating what auto-generation would produce from
  metadata appConfigExamples
• Guidance that only entries overriding specific test-environment
  values justify maintaining the file

This addresses a gap identified during NFS (app-next) migration reviews where legacy config entries carry forward unnecessarily.

---

Closes #3534

Post-script verification

• Branch is not main/master (agent/3534-dynamic-plugins-review-guidance)
• Secret scan passed (gitleaks — 102e37162b04bc906dbe8dd95e4d7414c0da5339..HEAD)
• Pre-commit hooks passed (authoritative run on runner)
• Tests ran inside sandbox

[openshift-ci]

Hi @fullsend-ai-coder[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 3:46 PM UTC · Completed 4:00 PM UTC

Commit: c0a54b0 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $3.10

[fullsend-ai-review]

Review

Findings

Medium

• [protected-path] AGENTS.md — This file is a protected path (governance/infrastructure). The PR links to issue Add AGENTS.md review guidance for dynamic-plugins.yaml minimality in NFS test configs #3534 and explains the rationale for the change, but human approval is always required for modifications to protected paths regardless of context.

Low

• [internal-consistency] AGENTS.md:316 — Line 316 states "ALL metadata files are read to auto-generate the complete plugin configuration," while the new text clarifies that auto-generation only includes plugins from the workspace's own metadata/*.yaml files. Investigation of the implementation (readWorkspacePackages in smoke-tests-native/src/workspace.ts) confirms the new text is factually correct — auto-generation is workspace-scoped. The existing phrasing on line 316 is contextually correct but could be slightly clearer by saying "all of the workspace's metadata files" instead of "ALL metadata files." Optional follow-up improvement.

[fullsend-ai-review]

Note: The following review comments could not be posted on the diff (GitHub returned 422) and are included here instead:

• AGENTS.md (file-level): Line 316 · [low] internal-consistency

Line 316 states 'ALL metadata files are read' which could be misread as cross-workspace, but in context it clearly means 'all metadata files for that workspace.' The new PR text is factually correct (confirmed by implementation in smoke-tests-native/src/workspace.ts readWorkspacePackages). Optional clarity improvement: amend line 316 to say 'all of the workspace metadata files are read.'

Suggested fix: Optional: amend line 316 from 'ALL metadata files are read' to 'all of the workspace metadata files are read' to eliminate any ambiguity.