Skip to content

horizontally align top and bottom pagination widgets - #275

Merged
keithchong merged 1 commit into
redhat-developer:mainfrom
aali309:GITOPS-10908
Aug 21, 2026
Merged

horizontally align top and bottom pagination widgets#275
keithchong merged 1 commit into
redhat-developer:mainfrom
aali309:GITOPS-10908

Conversation

@aali309

@aali309 aali309 commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Signed-off-by: Atif Ali <atali@redhat.com>
@openshift-ci
openshift-ci Bot requested review from keithchong and wtam2018 August 21, 2026 16:02
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6fd03b81-f4e0-4962-9998-9977210ff2e1

📥 Commits

Reviewing files that changed from the base of the PR and between 08f4d34 and 1481e39.

📒 Files selected for processing (2)
  • src/gitops/components/shared/DataView/GitOpsDataViewTable.scss
  • src/gitops/components/shared/DataView/GitOpsDataViewTable.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Improved GitOps table pagination alignment.
    • Removed extra bottom pagination padding for a more consistent layout.
    • Updated bottom pagination positioning to remain aligned with the table toolbar.

Walkthrough

The GitOps data view now applies scoped table styling and renders bottom pagination statically. The pagination component forwards the optional isStatic property to PatternFly.

Changes

GitOps table pagination

Layer / File(s) Summary
Align bottom pagination
src/gitops/components/shared/DataView/GitOpsDataViewTable.tsx, src/gitops/components/shared/DataView/GitOpsDataViewTable.scss
The DataView imports scoped styles and uses the gitops-data-view-table class. Bottom pagination enables static rendering. GitOpsPagination forwards isStatic to PatternFly. The styles remove inline padding from bottom pagination.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 1481e

This localized styling change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Suggested reviewers: keithchong, wtam2018

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the primary change: horizontal alignment of the top and bottom pagination widgets.
Description check ✅ Passed The description links to GITOPS-10908, which matches the stated objective and the pagination alignment changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.34%. Comparing base (80b0f68) to head (1481e39).
⚠️ Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
...components/shared/DataView/GitOpsDataViewTable.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   11.39%   12.34%   +0.95%     
==========================================
  Files         168      171       +3     
  Lines        6627     6835     +208     
  Branches     2274     2258      -16     
==========================================
+ Hits          755      844      +89     
- Misses       5635     5990     +355     
+ Partials      237        1     -236     
Flag Coverage Δ
unit-tests 12.34% <0.00%> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@keithchong keithchong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithchong
keithchong merged commit 518afce into redhat-developer:main Aug 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants