fix: do not rethrow handled exec errors into parent scope (CRW-12908) - #369
Merged
Conversation
The catch already delivers the failure via onError and future.completeExceptionally; rethrowing into a parentScope with no exception handler produced SEVERE 'Unhandled exception in Dispatchers.IO' log entries for every dropped exec websocket (e.g. WebSocketStreamHandler IllegalStateException). Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
runCatching(...).getOrNull() silently turned unparseable status output into an empty (not ready) status, making 'IDE not ready after 120s' undebuggable. Warn with a snippet of the raw output so the actual cause is visible in idea.log. Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 0.00% 38.36% +38.36%
==========================================
Files 4 121 +117
Lines 26 5310 +5284
Branches 0 1023 +1023
==========================================
+ Hits 0 2037 +2037
- Misses 26 2990 +2964
- Partials 0 283 +283 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Log pod name, container, and timeout on entry; poll progress at debug every 5s; success/failure with elapsed time. Pod-not-running state also logged at info so silent empty-status returns are visible in idea.log. Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
vrubezhny
approved these changes
Sep 4, 2026
vrubezhny
left a comment
vrubezhny
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://redhat.atlassian.net/browse/CRW-12908