Skip to content

fix: list all DevWorkspaces, handle inaccessible templates gracefully (CRW-11897) - #359

Merged
adietish merged 1 commit into
redhat-developer:mainfrom
adietish:crw-11897
Sep 1, 2026
Merged

fix: list all DevWorkspaces, handle inaccessible templates gracefully (CRW-11897)#359
adietish merged 1 commit into
redhat-developer:mainfrom
adietish:crw-11897

Conversation

@adietish

@adietish adietish commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

fixes https://redhat.atlassian.net/browse/CRW-11897

In this PR we're listing all workspaces regardless of editor. We only allow to connect to workspaces with JetBrains or unknown editors though
image

How to test:

  1. EXEC: create several workspaces with different editors (vscode, jetbrains pycharm/golang/ultimate/..., editor definition
  2. EXEC: launch plugin, connect to cluster and proceed to the list of workspaces
  3. EXEC: try connecting to the different workspaces
  4. ASSERT: you can only connect to jetbrains editor based workspaces and the unknown ones (ws created with an editor definition). With the unknown editor workspace you are warned that connecting may fail.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b8eca23c-c7ab-4ce7-8c62-9a793284d4e0


Comment @coderabbitai help to get the list of available commands.

@adietish adietish changed the title Crw 11897 fix: list all DevWorkspaces, handle inaccessible templates gracefully (CRW-11897) Aug 1, 2026
@adietish adietish self-assigned this Aug 1, 2026
@codecov-commenter

codecov-commenter commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.91033% with 298 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.30%. Comparing base (71098f6) to head (31856c8).
⚠️ Report is 423 commits behind head on main.

Files with missing lines Patch % Lines
.../gateway/view/steps/DevSpacesWorkspacesStepView.kt 0.00% 89 Missing ⚠️
...ateway/view/steps/workspaces/DevWorkspacesTable.kt 0.00% 61 Missing ⚠️
...tlin/com/redhat/devtools/gateway/DevSpacesIcons.kt 0.00% 31 Missing ⚠️
...steps/workspaces/DevWorkspaceTableCellRenderers.kt 0.00% 31 Missing ⚠️
...s/gateway/view/steps/workspaces/WorkspacesWatch.kt 0.00% 27 Missing ⚠️
...ay/view/steps/workspaces/DevWorkspaceTableModel.kt 78.00% 7 Missing and 4 partials ⚠️
...ateway/devworkspace/WorkspaceEditorInfoProvider.kt 86.84% 2 Missing and 8 partials ⚠️
.../redhat/devtools/gateway/server/RemoteIDEServer.kt 41.17% 7 Missing and 3 partials ⚠️
...lin/com/redhat/devtools/gateway/view/ui/Dialogs.kt 0.00% 10 Missing ⚠️
.../com/redhat/devtools/gateway/view/ui/SwingUtils.kt 0.00% 7 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##            main     #359       +/-   ##
==========================================
+ Coverage   0.00%   38.30%   +38.30%     
==========================================
  Files          4      121      +117     
  Lines         26     5289     +5263     
  Branches       0     1014     +1014     
==========================================
+ Hits           0     2026     +2026     
- Misses        26     2982     +2956     
- Partials       0      281      +281     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adietish
adietish force-pushed the crw-11897 branch 10 times, most recently from 4f4494e to 3f1d6b7 Compare August 20, 2026 22:57
@adietish
adietish marked this pull request as ready for review August 24, 2026 12:13
@adietish
adietish force-pushed the crw-11897 branch 5 times, most recently from 5e6032a to 08ee94d Compare August 24, 2026 21:48
@adietish

Copy link
Copy Markdown
Collaborator Author

@azatsarynnyy, @vrubezhny, @msivasubramaniaan: please review

… (CRW-11897)

Avoid Fatal IDE errors and hidden JetBrains workspaces when
devworkspacetemplates list returns 401/403/404. Show editor
labels, fail fast without idea-server container.

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

@azatsarynnyy azatsarynnyy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing the PR, I was able to connect to the workspace with a known IDE (WebStorm).

Also, I tested connecting to a workspace with unknown editor (Toolbox) and got the expected steps:
1
Image
2
Image
3
Image

Thanks @adietish!

@adietish
adietish merged commit 114bbff into redhat-developer:main Sep 1, 2026
7 checks passed
@adietish
adietish deleted the crw-11897 branch September 1, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants