fix: list all DevWorkspaces, handle inaccessible templates gracefully (CRW-11897) - #359
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 0.00% 38.30% +38.30%
==========================================
Files 4 121 +117
Lines 26 5289 +5263
Branches 0 1014 +1014
==========================================
+ Hits 0 2026 +2026
- Misses 26 2982 +2956
- Partials 0 281 +281 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4f4494e to
3f1d6b7
Compare
5e6032a to
08ee94d
Compare
|
@azatsarynnyy, @vrubezhny, @msivasubramaniaan: please review |
… (CRW-11897) Avoid Fatal IDE errors and hidden JetBrains workspaces when devworkspacetemplates list returns 401/403/404. Show editor labels, fail fast without idea-server container. Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
azatsarynnyy
left a comment
There was a problem hiding this comment.
While testing the PR, I was able to connect to the workspace with a known IDE (WebStorm).
Also, I tested connecting to a workspace with unknown editor (Toolbox) and got the expected steps:
1

2

3

Thanks @adietish!
fixes https://redhat.atlassian.net/browse/CRW-11897
In this PR we're listing all workspaces regardless of editor. We only allow to connect to workspaces with JetBrains or unknown editors though

How to test: