fix: avoid bind exception when reconnecting after failure - #150
Closed
adietish wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 4 25 +21
Lines 26 887 +861
Branches 0 118 +118
======================================
- Misses 26 887 +861 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adietish
marked this pull request as ready for review
August 8, 2025 15:58
adietish
changed the title
adietish
changed the title
adietish
force-pushed
the
avoid_bindexception
branch
3 times, most recently
from
August 8, 2025 17:59
9e8e4b3 to
ef92153
Compare
adietish
marked this pull request as draft
August 11, 2025 21:44
adietish
force-pushed
the
avoid_bindexception
branch
2 times, most recently
from
August 15, 2025 19:19
8c0f8b4 to
a2c90ed
Compare
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish
force-pushed
the
avoid_bindexception
branch
from
August 18, 2025 10:33
a2c90ed to
40c209d
Compare
Collaborator
Author
|
Cannot replicate the failure. Therefore closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to connect to a workspace via link and it then fails, you get a
BindExceptionif you try again. That's because the server socket, that's used to forward, isn't closed if connecting fails.