Jetbrains Gateway cannot connect after 3.5h IDLE period - #148
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 4 25 +21
Lines 26 1008 +982
Branches 0 157 +157
======================================
- Misses 26 1008 +982 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
86b4d42 to
7dd1828
Compare
azatsarynnyy
left a comment
azatsarynnyy
left a comment
There was a problem hiding this comment.
I run the plugin from vrubezhny:fix-cannot-connect-when-idle,
and I noticed the UI differs from what is shows on the screenscasts
@vrubezhny do you think I missed some steps?
azatsarynnyy
left a comment
azatsarynnyy
left a comment
There was a problem hiding this comment.
@adietish could you please verify if the PR fixes the original issue you reported
Fixes eclipse-che/che#23485 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
7dd1828 to
58a72b8
Compare
adietish
left a comment
adietish
left a comment
There was a problem hiding this comment.
Couldn't verify that it really helps. Nevertheless, this feels like an improvements. I'd merge it and I'll keep trying to reproduce the issue
| onDevWorkspaceStopped: () -> Unit, | ||
| onDisconnected: () -> Unit | ||
| ) { | ||
| try { |
There was a problem hiding this comment.
nitpicking: I'd create separate methods for all 3 closing operations (closeForwarder(), stopDevWorkspace(), invokeOnDisconnected) and call them here.
| false | ||
| ) | ||
|
|
||
| val forwarder = Pods(devSpacesContext.client).forward(remoteIdeServer.pod, 5990, 5990) |
There was a problem hiding this comment.
#forward can fail, too ex. if local port is already bound.
| .startNewClient( | ||
| Lifetime.Eternal, | ||
| URI(remoteIdeServerStatus.joinLink), | ||
| URI(remoteIdeServerStatus.joinLink!!), |
There was a problem hiding this comment.
I saw situations where the joinLink was null. I believe that it would be better to check the joinLink for being non-empty and throw instead of asserting it to be non-null (!!)
|
Closing this PR as outdated. The following issues/PRs are completely cover the changes previously made in this PR:
|
4 participants
When the DevSpaces WS isn't started or ready, this PR starts the WS and waits for its readiness before starting the Remote IDE Client:
cold-start_spedup.mp4
In some cases the Remote IDE Server cannot correctly process requests (status/stop) - usually when this happens we have no other option to recover, but the full DevSpaces Pod restart. so. with this PR, the User is asked to restart and if agreed, the DevSpaces Pod gets terminated and then restarted, which in its turn makes the Remote IDE server to correctly start:
remote-ide-not-responsive_spedup.mp4
Fixes eclipse-che/che#23485