ci(github): limit GPU test steps to 10 minutes - #354
Merged
Merged
Conversation
# 🔧 CI/CD - Limit GPU unit test execution to 10 minutes. - Apply the same 10-minute limit independently to both integration test cases. - Catch hangs and runtime regressions using step-level timeouts. Co-authored-by: Codex <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Nyanpasu 审查看板审查状态: ✅ 已通过 审查版本: 已完成审查并提交通过,未发现需修改的问题。已核对超时范围、清理路径和近期成功运行耗时;pre-commit 已通过,其余 CI 尚在运行。缺少 H20 硬件,未在本地运行 GPU/多节点测试或实测超时清理。 没有未解决的审查问题。
Powered by Nyanpasu with gpt-6-astra medium, please check the suggestions carefully.
|
rai-studio-bot
approved these changes
Sep 22, 2026
rai-studio-bot
left a comment
There was a problem hiding this comment.
审查通过,未发现需要修改的问题。已核对两个工作流的测试步骤、集成矩阵、容器清理和设备释放路径;配置符合 GitHub 的步骤超时语义。最近一次 main 的 GPU 单测耗时 6 分 37 秒,两项集成测试分别为 6 分 13 秒和 5 分 59 秒。
本地 diff 检查通过;本 PR 的 pre-commit 已通过,其余 CI 仍在运行。本地未运行 GPU/多节点集成测试,因缺少所需 H20 硬件;未实测超时触发后的清理。
Powered by Nyanpasu with gpt-6-astra medium, please check the suggestions carefully.
DrRyanHuang
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Limit GPU unit tests and each of the two GPU integration test cases to 10 minutes of test execution.
Why
GPU unit tests normally take about 6 minutes. A tighter execution limit catches hangs and unexpected runtime regressions sooner. Relates to the runtime regression reported on PR #273.
How
Set
timeout-minutes: 10onRun unittestandRun integration test. Each integration matrix job gets its own limit. Image preparation and GPU acquisition retain their separate budgets, and the existing cleanup and artifact steps run after a test timeout.Testing
pre-commit run --all-files --show-diff-on-failuregit diff --cached --checkType of Change