Skip to content

ci(github): limit GPU test steps to 10 minutes - #354

Merged
SigureMo merged 1 commit into
mainfrom
codex/ci-test-timeouts
Sep 22, 2026
Merged

SigureMo merged 1 commit into
mainfrom
codex/ci-test-timeouts

Conversation

@SigureMo

@SigureMo SigureMo commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

What

Limit GPU unit tests and each of the two GPU integration test cases to 10 minutes of test execution.

Why

GPU unit tests normally take about 6 minutes. A tighter execution limit catches hangs and unexpected runtime regressions sooner. Relates to the runtime regression reported on PR #273.

How

Set timeout-minutes: 10 on Run unittest and Run integration test. Each integration matrix job gets its own limit. Image preparation and GPU acquisition retain their separate budgets, and the existing cleanup and artifact steps run after a test timeout.

Testing

  • pre-commit run --all-files --show-diff-on-failure
  • git diff --cached --check
  • GPU unit and integration tests were not run locally because they require the H20 runner hardware; they will run in PR CI.

Type of Change

  • CI/CD or build changes
This PR is co-authored with @codex (gpt-6 astra xhigh)

# 🔧 CI/CD

- Limit GPU unit test execution to 10 minutes.
- Apply the same 10-minute limit independently to both integration test cases.
- Catch hangs and runtime regressions using step-level timeouts.

Co-authored-by: Codex <noreply@openai.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T11:05:09.632180Z 3528bf5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rai-studio-bot

rai-studio-bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Nyanpasu 审查看板

审查状态: ✅ 已通过

审查版本: 3528bf5e5a6685ed66a35e92b0f2f82b6b8803d8

已完成审查并提交通过,未发现需修改的问题。已核对超时范围、清理路径和近期成功运行耗时;pre-commit 已通过,其余 CI 尚在运行。缺少 H20 硬件,未在本地运行 GPU/多节点测试或实测超时清理。

没有未解决的审查问题。

Powered by Nyanpasu with gpt-6-astra medium, please check the suggestions carefully.

@rai-studio-bot rai-studio-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

审查通过,未发现需要修改的问题。已核对两个工作流的测试步骤、集成矩阵、容器清理和设备释放路径;配置符合 GitHub 的步骤超时语义。最近一次 main 的 GPU 单测耗时 6 分 37 秒,两项集成测试分别为 6 分 13 秒和 5 分 59 秒。

本地 diff 检查通过;本 PR 的 pre-commit 已通过,其余 CI 仍在运行。本地未运行 GPU/多节点集成测试,因缺少所需 H20 硬件;未实测超时触发后的清理。

Powered by Nyanpasu with gpt-6-astra medium, please check the suggestions carefully.

@SigureMo
SigureMo merged commit c7d2847 into main Sep 22, 2026
7 checks passed
@SigureMo
SigureMo deleted the codex/ci-test-timeouts branch September 22, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants