Conversation
# ⭐ Feature - Add deterministic mock, Search-R1 and configurable external search. - Normalize results and preserve non-terminal errors with bounded retries. - Forward search settings to Ray workers without tracing credentials. - Document backend configuration and deployment requirements. # ✅ Tests - Cover HTTP adapters, failure handling, agent continuation and launchers. - Pass all 86 DeepEyes-V2 tests and all repository pre-commit checks. - Live search services and GPU training were not available for validation.
Nyanpasu 审查看板审查状态: ✅ 已通过 审查版本: e5e1df6 新目标提交 e5e1df6 为 main 的干净合并:PR 相对 main 的差异与此前已批准的 ba3977d 逐字节一致,main 侧改动不涉及示例文件及其依赖;合并后 86 项示例测试全部通过,启动脚本语法检查通过。未发现新问题,同意合入。验证边界:未使用真实 Search-R1 服务或外部 API 凭据,未运行多节点 GPU/Ray 训练。
没有未解决的审查问题。 提交范围 · 接收 10 · 建议移出 0 · 待确认 0接收 10 个文件 · 建议移出 0 个文件 · 待确认 0 个文件。移出与待确认部分暂停深审,不代表审查通过。
精简审查与验证依据
生产代码的必要性与替代方案
测试的必要性与替代方案
Powered by Nyanpasu with glm-5.3[1m] xhigh, please check the suggestions carefully.
|
rai-studio-bot
left a comment
There was a problem hiding this comment.
已审查目标提交,未发现需要修改的问题,同意合入。核对了三个搜索后端、结果归一化、错误恢复和启动脚本环境传递;相关 CPU 测试 86 passed,两个启动脚本语法及 diff 检查通过。
当前无 CI 检查记录;未使用真实检索服务或外部 API 凭据,且缺少多节点 GPU/Ray 环境,因此未验证真实服务与训练部署。
# 🐛 Bug Fix - Stub the optional OpenAI SDK in the scripted agent test so CPU CI can run without it. - Verify real read timeouts independently of retry request timing. --- # ♻️ Refactor - Remove repeated validation of normalized search values and redundant launcher guards. --- # ✅ Tests - All 86 DeepEyes example tests pass without the OpenAI SDK installed. - Full pre-commit checks and launcher syntax checks pass.
rai-studio-bot
left a comment
There was a problem hiding this comment.
已复核新提交,未发现新的问题,同意合入。重复校验的移除保留了原有约束,启动脚本仍保护凭据输出;相关 CPU 测试再次通过(86 passed),启动脚本语法及 diff 检查通过。
CI 尚在运行;本地未验证真实搜索服务或多节点 GPU/Ray 训练。
|
@SigureMo 您好,Task No.10已经完成,辛苦有空Review下,感谢。 |
rai-studio-bot
left a comment
There was a problem hiding this comment.
复核结论:同意合入
已审查目标提交 e5e1df62(合并 main)。本轮核验:该提交为 main 的干净合并,PR 相对 main 的差异与此前已批准的 ba3977dc 版本逐字节一致;main 侧新增改动不涉及本示例文件或其依赖导入。在合并后的代码上复跑 tests/examples/deepeyes_v2_agentic,86 项全部通过;两个启动脚本 bash -n 语法检查通过。验证边界保持不变:未使用真实 Search-R1 服务或外部 API 凭据,未运行多节点 GPU/Ray 训练。
审查看板:#342 (comment)
What
Replace the DeepEyes-V2 text-search placeholder with deterministic offline mock, Search-R1 retriever, and configurable external HTTP backends.
Why
Implements Task 10: DeepEyes-V2 真实网页搜索工具.
Relates to #321. Registered participant: WYXNICK (Task 10 registration); this task does not require an RFC.
The example needs real retrieval when configured while retaining an offline default without search credentials.
How
elapsed_timeanddatawithtitle,link,snippet, and nullabledate."Error"; real-backend failures never silently fall back to mock.Testing
Validated on macOS with Python 3.12:
pre-commit run --all-filespassespytest tests/) — full repository/GPU suite not run locallypython -m pytest tests/examples/deepeyes_v2_agentic -q --tb=short: 86 passed (upstream baseline: 12 passed).Both launcher scripts pass
bash -n;git diff --checkpasses.Tests cover deterministic offline behavior, Search-R1 and external GET/POST protocols through a local HTTP server, result mapping, malformed configuration/responses, empty results, timeout/retry behavior, credential redaction, Agent continuation after success/failure, and launcher environment propagation.
No Search-R1-compatible deployment was available, and no live external API credentials were used. These are protocol/integration tests with a local HTTP server and scripted model responses, not live E5/FAISS or Tavily validation. GPU training and real Ray deployment were not run; the README includes a separate configured-service smoke test.
Type of Change
Screenshots / Logs