Skip to content

Postgres db creds are refreshed every time not just inital reun#2994

Open
jland-redhat wants to merge 1 commit into
red-hat-data-services:masterfrom
jland-redhat:replace-maas-db-creds
Open

Postgres db creds are refreshed every time not just inital reun#2994
jland-redhat wants to merge 1 commit into
red-hat-data-services:masterfrom
jland-redhat:replace-maas-db-creds

Conversation

@jland-redhat

@jland-redhat jland-redhat commented Jul 16, 2026

Copy link
Copy Markdown

Noticed that on subsequent runs that postgres DB was not being updated.

This change is to just update every run

Solves the DB issue noted here:
https://redhat.atlassian.net/browse/RHOAIENG-77589

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jland-redhat

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

PostgreSQL Secret Refresh

Layer / File(s) Summary
Credential and secret refresh helpers
ods_ci/tasks/Resources/Database/configure_maas_postgres.sh
Adds helpers to load or generate PostgreSQL credentials and apply maas-db-config with a computed connection URL.
Provisioning and repeat-run refresh flow
ods_ci/tasks/Resources/Database/configure_maas_postgres.sh
Refreshes database secrets on existing PostgreSQL installations and applies them to both namespaces when they differ.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant configure_maas_postgres.sh
  participant PostgreSQL
  participant Kubernetes API
  configure_maas_postgres.sh->>PostgreSQL: Check readiness
  configure_maas_postgres.sh->>Kubernetes API: Load postgres-creds
  configure_maas_postgres.sh->>Kubernetes API: Apply maas-db-config in INFRA_NS
  configure_maas_postgres.sh->>Kubernetes API: Apply maas-db-config in APPS_NS when namespaces differ
Loading

Suggested reviewers: fedealonso

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main change: refreshing Postgres creds on every run, despite minor typos.
Description check ✅ Passed The description directly explains that Postgres is updated on subsequent runs, which matches the changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant