Skip to content

Add support for OpenShift version 4.22 in install_nfd.sh #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
san7ket merged 1 commit into from
Jul 16, 2026
+1 −0
Merged

Add support for OpenShift version 4.22 in install_nfd.sh #2993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ods_ci/tasks/Resources/Provisioning/GPU/NFD/install_nfd.sh
View file
Open in desktop

@github-actions github-actions Bot Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

ods-ci/ods_ci/tasks/Resources/Provisioning/GPU/NFD/install_nfd.sh

Line 32 in 80bfbdb

sed -i'' -e "s/<imageUrl>/$imageUrl/g" $NFD_INSTANCE

Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ declare -A images=(
["4.19"]="registry.redhat.io\/openshift4\/ose-node-feature-discovery-rhel9@sha256:d23fe6bcb36bdbe0e61a30f8ab7cb90e6dea25a399d87c3ba3d94415a61735b8"
["4.20"]="registry.redhat.io\/openshift4\/ose-node-feature-discovery-rhel9@sha256:fbd8db340dd4e4cda793b1f0453d42988bb8102d1061388827777bb848b067f2"
["4.21"]="registry.redhat.io\/openshift4\/ose-node-feature-discovery-rhel9@sha256:76a161a255a255eafcef4dc036adb8c0c8aadab2f0c57c3d3e19d5eea0ac5961"
["4.22"]="registry.redhat.io\/openshift4\/ose-node-feature-discovery-rhel9@sha256:ec0f732495473310dc9faaff27960da877d8b4ced76259fd48a14f9f456b16ea"
)
if [ "${images[$xyVersion]}" ]; then
imageUrl="${images[$xyVersion]}"
Expand Down
Loading