Hardcode ReplaceServiceArgumentRector into ContainerInterfaceServiceToServiceContainerRector - #999
Merged
Conversation
…rviceToServiceContainerRector The rule only ever handled one Symfony 6.0 BC break: the removal of the Psr\Container\ContainerInterface and Symfony\Component\DependencyInjection\ContainerInterface aliases of the "service_container" service. Hardcode both values, drop the configuration and its value object, and bond the rule to symfony/dependency-injection >=6.0 via ComposerPackageConstraintInterface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReplaceServiceArgumentRectorwas configurable, but both sets configured it with the very same 2 values. It only ever covered a single Symfony 6.0 BC break:So the configuration was a needless indirection. The rule is now hardcoded, renamed to
ContainerInterfaceServiceToServiceContainerRector, and version-bonded tosymfony/dependency-injection >=6.0viaComposerPackageConstraintInterface.What the rule does
Changes
ReplaceServiceArgumentRector→ContainerInterfaceServiceToServiceContainerRector, no longerConfigurableRectorInterfaceReplaceServiceArgumentvalue object removed - no other rule uses itContainerInterfaceFQNs moved toSymfonyClassenum constantscomposer-based.phpin the plainrules()list under// symfony/dependency-injection 6.0, the version now comes from the rule itselfsymfony60-dependency-injection.phpuses plainrule()