Repository navigation
Keep blank lines between methods in event subscriber attribute rules - #1101
Merged
Merged
Conversation
TomasVotruba
deleted the
preserve-blank-lines-eventsubscriber-fixtures
branch
October 29, 2026 08:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to rectorphp/rector-src#8886.
That rector-src PR fixes the format-preserving printer so removing the last interface from a class no longer collapses the blank lines between its methods. These fixtures encoded the old collapsed output; this regenerates them to the corrected spacing.
Affected rules:
EventSubscriberToAttributeRector(multiple_mixed_methods,multiple_event_subscriptions)MessageSubscriberInterfaceToAttributeRector(messagesubscriber-yield)Note: CI stays red until rector-src#8886 is merged and released, since it pulls
rector/rector-src dev-mainwhich does not yet contain the printer fix.