[CodeQuality] Re-use parent protected property in ControllerMethodInjectionToConstructorRector - #1003
Merged
Merged
Conversation
…ectionToConstructorRector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a parent controller already exposes the very same service as a
protected/publicproperty, the rule added a duplicate constructor property with the same name — shadowing the parent one.Now the parent property is re-used: the action param is still removed and its usage rewritten to
$this->..., but no new constructor dependency is added.Parent:
Child:
final class SomeController extends ParentController { #[Route('/example', name: 'example')] - public function example(LoggerInterface $logger) + public function example() { - $logger->log('level', 'value'); + $this->logger->log('level', 'value'); } }A
privateparent property is still not accessible, so that case keeps adding an own dependency (covered by the existingchild_of_parent_with_private_promoted_propertyfixture). The re-use also requires the parent property type to be compatible with the param type.