Skip to content

[perf] Skip wrapBinaryOpWithBrackets() for CallLike nodes on BetterStandardPrinter::p() - #8890

Merged
TomasVotruba merged 2 commits into
mainfrom
perf-print-comma
Oct 29, 2026
Merged

TomasVotruba merged 2 commits into
mainfrom
perf-print-comma

Conversation

@samsonasik

Copy link
Copy Markdown
Member

wrapBinaryOpWithBrackets() never changes anything for CallLike nodes, so p() now skips it for them.

php bench/better_standard_printer_call_like_bench.php

main This PR
CPU per print ~45.8 ms ~43.3 ms

@TomasVotruba

Copy link
Copy Markdown
Member

👍

@TomasVotruba
TomasVotruba merged commit 25d54e8 into main Oct 29, 2026
51 checks passed
@TomasVotruba
TomasVotruba deleted the perf-print-comma branch October 29, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants