[ondrejmirtes]

Bumps phpstan/phpstan to ^2.3.4 and phpstan/phpdoc-parser to ^2.4, with the minimal fixes to keep everything green.

phpdoc-parser 2.4 adds NameNode (FullyQualifiedNameNode, RelativeNameNode), and PHPStan 2.3.4's Type::toPhpDocNode() now returns FullyQualifiedNameNode for class names. Because of this:

• NameImportingPhpDocNodeVisitor and ClassRenamePhpDocNodeVisitor handle FullyQualifiedNameNode the same way as a written \Foo\Bar, so auto-import and class renaming in docblocks keep working.
• ShortenedObjectType, ShortenedGenericObjectType, AliasedObjectType and NonExistingObjectType override toPhpDocNode() to return RelativeNameNode, so they keep printing as written.
• GenericTypeNode::$type can now be a NameNode, so three places check for IdentifierTypeNode before reading ->name.

A follow-up PR will replace the PHPStanStaticTypeMapper mappers with Type::toPhpDocNode() and Type::toNativePhpTypeNode().

[ondrejmirtes]

This bump should be merged and released soon. Rector 2.8.2 does not work with PHPStan 2.3.4.

rector/rector requires phpstan/phpstan: ^2.3.3, so composer installs PHPStan 2.3.4. Rector ships its own phpdoc-parser 2.3.12, and preload.php loads it before the PHPStan phar. The toPhpDocNode() method in PHPStan 2.3.4 needs the name nodes from phpdoc-parser 2.4. When Rector describes a closure, generic or object type, it fails:

Class "PHPStan\PhpDocParser\Ast\Type\FullyQualifiedNameNode" not found

This PR ships phpdoc-parser 2.4 in the Rector build and requires PHPStan ^2.3.4. The rector_laravel_rector_dev job fails for the same reason: it installs the current rector/rector:dev-main build, not this PR. It will pass after this PR is merged and the scoped build runs.

[ondrejmirtes]

rector-doctrine gets fixed here rectorphp/rector-doctrine#544

[SanderMuller]

Same root cause, different symptom, for anyone searching:

PHPStan\PhpDocParser\Ast\Type\CallableTypeNode::__construct(): Argument #1 ($identifier) must be of type PHPStan\PhpDocParser\Ast\Type\IdentifierTypeNode, PHPStan\PhpDocParser\Ast\Type\FullyQualifiedNameNode given

It only shows up with a cold cache (--clear-cache or a fresh CI run). A warm Rector cache hides it.

[ondrejmirtes]

Users can lock to PHPStan 2.3.3 before this PR is released.

[samsonasik]

Please run:

composer preload

to regenerate preload files.

[ondrejmirtes]

Done

[samsonasik]

Thank you @ondrejmirtes

[samsonasik]

@TomasVotruba let's create new immediate release for it to fix reported bug rectorphp/rector#9947

[samsonasik]

@TomasVotruba I've released rector 2.8.3 for it 👍

https://github.com/rectorphp/rector/releases/tag/2.8.3