Repository navigation
Cache aliased uses per file in AliasUsesResolver - #8684
Closed
TomasVotruba wants to merge 1 commit into
Closed
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AliasClassNameImportSkipVoterruns once perFullyQualifiednode during name importing. Each call delegated toAliasUsesResolver::resolveFromNode(), which re-traversed the whole file stmts to collectuse X as Ynames - even though that result is file-global and identical for every node in the pass.A file with N fully-qualified names did N full stmt traversals to compute the same alias list N times, on every convergence iteration.
Change
AliasUsesResolvernow caches the aliased-use list per file, keyed byFileidentity +getNewStmtsVersion()- same invalidation pattern already used byShortNameResolver::resolveShortClassLikeNames().resolveFromFile(File)replacesresolveFromNode(Node, array); the voter calls it. The removed node argument was only ever type-checked, never a namespace node, so behavior is unchanged.One traversal per file stmts version instead of one per imported name.
Tests
Existing import suites green (
rules-tests/CodingStyle/ClassNameImport,ImportFullyQualifiedNamesRector,tests/Issues/AutoImport*,NamespacedUseAutoImport, docblock import) - 148 tests. ECS + PHPStan clean on changed files.First small step toward collapsing the per-node skip-voter re-traversals behind a single per-file import context.