Repository navigation
[CodeQuality] Speed up ExplicitReturnNullRector with single scoped walk and cheap bail before return type inference - #8656
Open
TomasVotruba wants to merge 1 commit into
Open
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
…lk and cheap bail before return type inference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of
ExplicitReturnNullRector. No behavior change - all 32 fixtures pass unchanged.The rule's only heavy operation is
ReturnTypeInferer::inferFunctionLike(), which resolves class reflection and the native type of every return expression. It previously ran on every method/function that lacks a native return type.What changed
gotoexists, whether any value-returningreturnexists, and the barereturn;nodes to rewrite. This replaces a separatefindFirstInFunctionLikeScoped()goto scan plus a secondtraverseNodesWithCallable()pass.stmts === null, abstract/interface);return- the inferred type can then never be avalue|voidunion, so the rule could never fire.Inference is only reached once both cheap conditions hold.
Measured effect
Rule run with per-call counters over a corpus of untyped methods:
inferFunctionLikecalls 1000 -> 0.value|void(rule fires): 20 -> 20, no false skip.The expensive inference is now avoided entirely on the common legacy shape, while the firing path is untouched.