Repository navigation
[perf] Skip scope fetch in ReturnTypeFromGetRepositoryDocblockRector without a docblock - #8632
Merged
Merged
Conversation
…without a docblock The rule reads the native return type from the @return docblock, but fetched a scope and ran the getRepository check before touching the docblock. A method without a docblock has no @return to read, so it is a no-op. Add a getDocComment() guard before the scope fetch. Behaviour unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the RenameClassRector phpdoc-guard optimization.
ReturnTypeFromGetRepositoryDocblockRectorreads the native return type from the@returndocblock, but fetched a scope and ran thegetRepositoryreturn check before touching the docblock. A method without a docblock has no@returnto read, so it always ends inreturn null.Add a
getDocComment() !== nullguard right after the already-typed check and beforeScopeFetcher::fetch(), so doc-less methods skip the scope fetch. Behaviour identical.Tests green, ECS + PHPStan level 8 clean.