Repository navigation
[Renaming] Speed up RenameClassRector by deferring oldToNewTypes build - #8612
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassRenamer::renameNode()is called for everyFullyQualified,Name,Property,FunctionLike,Expression,ClassLikeandIf_node across the whole codebase.It ran
createOldToNewTypes()as the first statement on every call, which doesserialize($oldToNewClasses)+ a hash of the full rename map. With large rename maps (Symfony/Doctrine/PHPUnit sets), that serialize+hash per node dominated the rule self-time in profiling.The built
$oldToNewTypesis only used inside the phpdoc branch.FullyQualifiedandNamenodes - the bulk - return early and never touch it. This defers the build to the point of use, so the serialize+hash runs only for phpdoc-bearing nodes.No behavior change; tests unchanged and passing.