Repository navigation
Bump class-leak to ^2.3.3, remove stale and redundant class-leak skips - #8588
Merged
Merged
Conversation
…le fixtures Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeUiuxXmYgChK2jkSHJYLi
…ck collection detection Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeUiuxXmYgChK2jkSHJYLi
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trims the "Active Classes" class-leak step from 19
--skip-typeentries down to 5.SingleServiceRegistrationRuletest fixtures (DuplicateRegistrationFactory,SingleRegistrationFactory) no longer exist.@param TypeMapperInterface[] $typeMappersas injected, which covers every one of them.tomasvotruba/class-leak: ^2.3.3.Verified locally with 2.3.3 installed:
[OK] All services are used.The remaining 5 skips are a different kind (a class used only in
scoper.php, one used only in.neon, test fixtures loaded by file path, andBinaryOpConditionsCollector, which is only used in tests).🤖 Generated with Claude Code
https://claude.ai/code/session_01BeUiuxXmYgChK2jkSHJYLi