Repository navigation
Bump to PHPStan 2.3 - #8529
Closed
TomasVotruba wants to merge 2 commits into
Closed
Bump to PHPStan 2.3#8529TomasVotruba wants to merge 2 commits into
TomasVotruba wants to merge 2 commits into
Conversation
Member
|
I already created PR #8528 for it. |
Member
Author
|
I see, I'll leave you to it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
phpstan/phpstanto^2.3.PHPStan 2.3 flags a provably-dead
$removeStmtKeys === []guard inRemoveUselessAssignFromPropertyPromotionRector(the array is always non-empty at that point, since the earlier loop either returns early or appends on every iteration over non-empty stmts). Removed the dead check.