[CodingStyle] Deprecate NullableCompareToNullRector - #8268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
NullableCompareToNullRector.The rule turns a truthy
ifcheck on a nullable object into an explicit!== nullcompare:The result is still a weak, ambiguous comparison.
!== nullonly tells us "not null" — it says nothing about what the value actually is, and it silently keeps working when the type later widens to a union of more classes.An
instanceofcheck is stronger and self-documenting:That is what the
instanceofrule set already provides, so this rule only competes with it while producing the weaker output.Rule is removed from the coding style level set and now throws on use, in line with the other recent deprecations.