[CodingStyle] Deprecate EncapsedStringsToSprintfRector - #8265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate
EncapsedStringsToSprintfRector.Turning string interpolation into
sprintf()/concat is a personal preference, not a correctness or upgrade change. On top of that, the rule output is ambiguous - the same input produces a different result depending on the value type and thealwaysconfiguration:Same input, two different output styles - one
sprintf(), one concat. Withalways: truethe second one becomessprintf()too. Hard to predict, and the "more readable" claim goes both ways.Rule is kept as a deprecated no-op that throws when used, and removed from the CodingStyle level.