Skip to content

[Configuration] Load single composer-based Symfony set in withComposerBased() - #8259

Merged
TomasVotruba merged 1 commit into
mainfrom
load-symfony-composer-based-set
Aug 2, 2026
Merged

[Configuration] Load single composer-based Symfony set in withComposerBased()#8259
TomasVotruba merged 1 commit into
mainfrom
load-symfony-composer-based-set

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Same treatment as PHPUnit in #8255: withComposerBased(symfony: true) now loads the single composer-based Symfony set instead of the whole SetGroup::SYMFONY group.

Every rule in that set declares the exact Symfony package + version its target API was added in, so there is no need to load all version sets and let them overlap.

 if ($phpunit) {
     // single set, as every rule inside is bound to the installed PHPUnit version on its own
     $this->sets[] = PHPUnitSetList::COMPOSER_BASED;
 }
+
+if ($symfony) {
+    // single set, as every rule inside is bound to the installed Symfony package version on its own
+    $this->sets[] = SymfonySetList::COMPOSER_BASED;
+}

Blocked until SymfonySetList::COMPOSER_BASED lands in rector-symfony dev-main - CI is red until then.

@TomasVotruba
TomasVotruba enabled auto-merge (squash) August 2, 2026 09:01
@TomasVotruba
TomasVotruba merged commit d453be6 into main Aug 2, 2026
78 of 79 checks passed
@TomasVotruba
TomasVotruba deleted the load-symfony-composer-based-set branch August 2, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant