[TypeDeclarationDocblocks] Deprecate AddReturnDocblockFromMethodCallDocblockRector - #8239
Merged
TomasVotruba merged 1 commit intoJul 31, 2026
Conversation
…ocblockRector The rule was experimental and never part of any set. It copies a @return docblock from the called method, which is risky: the source docblock can be incorrect or outdated, and the rule spreads that error further.
TomasVotruba
deleted the
deprecate-add-return-docblock-from-method-call-docblock
branch
July 31, 2026 11:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddReturnDocblockFromMethodCallDocblockRectorwas experimental and never made it into any set - it sat commented out inTypeDeclarationDocblocksLevelbehind a@todo test firstnote.The rule copies the
@returndocblock of the called method onto the caller. That is risky: the source docblock is unverified, and if it is incorrect or outdated, the rule spreads the wrong type further into the codebase.final class SomeController { + /** + * @return SomeEntity[] + */ public function getAll(): array { return $this->repository->findAll(); } } final class Repository { /** * @return SomeEntity[] */ public function findAll(): array { // ... } }If
Repository::findAll()docblock lies, the lie is now in two places.Rule now implements
DeprecatedInterfaceand throws onrefactor(), same as the recently deprecated data provider docblock rules (#8235). Tests and fixtures removed.