[scripts] Skip configurable rules in the unused-rules audit - #8236
Merged
Conversation
Configurable rules do nothing without their own configuration, so they can never be listed in a set. Reporting them as "not in any set" hides the rules that are genuinely missing from a set.
TomasVotruba
enabled auto-merge (squash)
July 30, 2026 21:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/list-unused-rules.phpreported 60 rules as "not in any set". 23 of them areConfigurableRectorInterfacerules — they do nothing without their own configuration, so they can never be listed in a set on their own. They are false positives that bury the rules genuinely missing from a set.Now they are filtered out and counted separately.
Before:
After:
The remaining 34 are the actionable ones — e.g.
Rector\Symfony\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector,Rector\PHPUnit\PHPUnit100\Rector\Class_\RemoveNamedArgsInDataProviderRectorandRector\PHPUnit\PHPUnit120\Rector\MethodCall\ExplicitMockExpectsCallRector, whose namespaces name the very set they are missing from.