Skip to content

Remove NullToStrictStringFuncCallArgRector from the PHP 8.1 set #8234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Jul 30, 2026
+6 −2
Merged

Remove NullToStrictStringFuncCallArgRector from the PHP 8.1 set #8234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d582f9d
Remove NullToStrictStringFuncCallArgRector from the PHP 8.1 set
TomasVotruba Jul 30, 2026
af903f2
Ignore set-registration rule for NullToStrictStringFuncCallArgRector
TomasVotruba Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions config/set/php81.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
use Rector\Php81\Rector\Class_\MyCLabsClassToEnumRector;
use Rector\Php81\Rector\Class_\SpatieEnumClassToEnumRector;
use Rector\Php81\Rector\FuncCall\NullToStrictIntPregSlitFuncCallLimitArgRector;
use Rector\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector;
use Rector\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector;
use Rector\Php81\Rector\MethodCall\RemoveReflectionSetAccessibleCallsRector;
use Rector\Php81\Rector\MethodCall\SpatieEnumMethodCallToEnumConstRector;
Expand All @@ -28,7 +27,6 @@
ReadOnlyPropertyRector::class,
SpatieEnumClassToEnumRector::class,
SpatieEnumMethodCallToEnumConstRector::class,
NullToStrictStringFuncCallArgRector::class,
NullToStrictIntPregSlitFuncCallLimitArgRector::class,

ArrayToFirstClassCallableRector::class,
Expand Down
6 changes: 6 additions & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ parameters:
- src/Console/Notifier.php
- src/Util/FileHasher.php

# deliberately kept out of the php81 set, as it fires too often to be applied by default;
# it stays available to register directly with withRules()
-
identifier: rector.upgradeDowngradeRegisteredInSet
path: rules/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector.php

# is nested expr
-
message: '#Access to an undefined property PhpParser\\Node\\Expr\:\:\$expr#'
Expand Down
Loading