Repository navigation
Make AddProphecyTraitRector idempotent - #806
Merged
Merged
Conversation
Check existing trait uses structurally before the reflection-based check, so the rule is not fooled by a class reflection that does not yet see the ProphecyTrait added on a previous pass and keeps re-adding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddProphecyTraitRectorrelied only on the class reflection to detect an already-presentProphecyTrait. When the rule runs more than once over the same class, the reflection does not yet see the trait added on the previous pass, so the rule keeps re-adding it.Now the rule checks the existing
TraitUsenodes on the class AST first, before the reflection-based check. This is immune to stale reflection and keeps the rule idempotent.Harmless today, but the upcoming rector-src node-traverser simplification drops the created-by-rule reprocessing guard, so each rule must settle on its own.
Test, ECS and PHPStan pass.