Repository navigation
Deprecate AddArrayResultColumnNamesRector - #533
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
deprecate-add-array-result-column-names
branch
from
October 17, 2026 20:40
7f2d008 to
19681f0
Compare
ArrayResult is rarely used, and the column keys this rule guesses need manual correction anyway. Mark as deprecated, drop the test, and remove it from the composer-based set.
TomasVotruba
force-pushed
the
deprecate-add-array-result-column-names
branch
from
October 17, 2026 21:02
19681f0 to
4de11f5
Compare
TomasVotruba
enabled auto-merge (squash)
October 17, 2026 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArrayResultis rarely instantiated manually, and the column names this rule guesses viaarray_keys($items[0] ?? [])need manual correction anyway.DeprecatedInterface+@deprecated, so Rector warns users who still register it directly, before it is removed.composer-basedset, following the convention that deprecated rules stay out of sets (a set membership turns the deprecation into a runtime warning for everyone).