Repository navigation
Register SortDirection rules in composer-based set + cover Expr\OrderBy::add() - #530
Merged
Merged
Conversation
Member
Author
|
@stof Could you review this one? Not sure if its the right trigger. |
|
Support for SortDirection in the QueryBuilder API was merged in 3.7.0 (in doctrine/orm#12449), not in 3.2.0 |
…t to doctrine/orm >=3.7
Member
Author
|
Updated 👍 How about now? |
JohJohan
approved these changes
Oct 5, 2026
Member
Author
|
Let's ship it 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #524 and #525, per rectorphp/rector#9919
The two
SortDirectionrules existed but were not wired into any set, so they never ran:DoctrineQueryBuilderSortDirectionRector(ORM 3.2)DoctrineOrderByAttributeSortDirectionRector(ORM 3.7)Both now registered in
composer-based.php, gated by their existingdoctrine/ormcomposer constraint - no manual registration needed per project.Also extends
DoctrineQueryBuilderSortDirectionRectorto coverDoctrine\ORM\Query\Expr\OrderBy::add(), the last deprecated string-direction entry point from the issue.Note: no PHP version gate. The
SortDirectionenum is native in PHP 8.6 and back-filled on PHP 8.1+ viasymfony/polyfill-php86, so the transform stays valid on 8.1+ with the polyfill.