Skip to content

feat(scheduled_actions): add nullable timezone column (chat#1881 3c) #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sweetmantech wants to merge 1 commit into from
Closed

feat(scheduled_actions): add nullable timezone column (chat#1881 3c) #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions supabase/migrations/20260722000000_add_timezone_to_scheduled_actions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
-- Add timezone column to scheduled_actions
-- Purpose: schedule weekly-report sends at 9am LOCAL time instead of 9am UTC
-- (currently the middle of the night in the US). See chat#1881 item 3c.

-- Change: add optional IANA timezone column with default NULL (NULL = UTC).
ALTER TABLE public.scheduled_actions
ADD COLUMN IF NOT EXISTS timezone text DEFAULT NULL;

@cubic-dev-ai cubic-dev-ai Bot Jul 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Invalid timezone values can be persisted and reach timezone-aware next_run derivation once API wiring lands, producing errors or incorrect scheduling. Consider enforcing the documented IANA-ID contract at the database boundary (or add a validated timezone domain/function) rather than accepting arbitrary text.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At supabase/migrations/20260722000000_add_timezone_to_scheduled_actions.sql, line 7:

<comment>Invalid timezone values can be persisted and reach timezone-aware `next_run` derivation once API wiring lands, producing errors or incorrect scheduling. Consider enforcing the documented IANA-ID contract at the database boundary (or add a validated timezone domain/function) rather than accepting arbitrary text.</comment>

<file context>
@@ -0,0 +1,10 @@
+
+-- Change: add optional IANA timezone column with default NULL (NULL = UTC).
+ALTER TABLE public.scheduled_actions
+ADD COLUMN IF NOT EXISTS timezone text DEFAULT NULL;
+
+COMMENT ON COLUMN public.scheduled_actions.timezone IS
</file context>


COMMENT ON COLUMN public.scheduled_actions.timezone IS
'IANA timezone id (e.g. America/New_York) the schedule is interpreted in. NULL = UTC.';