feat(home): catalog awareness on the authenticated home — reframe toward catalog-is-home (chat#1867/#1881 item 1869-r)#1869
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ea3f78043
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| hasValuation: valuation.show, | ||
| hasRuns: tasksState.view === "runs", | ||
| artistName: selectedArtist?.name || "", | ||
| catalogName: catalogsData?.catalogs?.[0]?.name || "", |
There was a problem hiding this comment.
When an artist is selected but has no artist-scoped measurements, useHomeValuation() returns false while HomeCatalogCta can still render the whole-catalog card with a valuation. Because this component only passes the claimed catalogName while hasValuation remains tied to the hero state, getHomeSuggestedPrompts emits “What's my catalog worth?” even though a valuation is already visible, sending users into a redundant estimate instead of the intended valuation-explanation prompt.
Useful? React with 👍 / 👎.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 9 files
Confidence score: 4/5
- In
components/Home/HomeCatalogCta.tsx, the CTA can render (and be clicked) in a pre-load state beforeuseCatalogs()resolves, so claimed-catalog users may be briefly routed toward the wrong marketing flow instead of their catalog experience—gate the CTA behind an explicit catalog-loading state before merging. - In
components/Home/HomeSuggestedPrompts.tsx, unresolveduseCatalogsdata can produce a generic seeded prompt while showing the same catalog-worth chip label, which creates subtle intent/label mismatch and inconsistent downstream prompt behavior—defer prompt seeding until catalog data is known (or align label and fallback prompt).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="components/Home/HomeCatalogCta.tsx">
<violation number="1" location="components/Home/HomeCatalogCta.tsx:17">
P2: Claimed-catalog users briefly see—and can click—the marketing valuation CTA on an uncached initial load before `useCatalogs()` resolves, then it swaps to the catalog card. Represent the catalog-loading state separately and suppress this fallback until the claimed-catalog query has settled.</violation>
</file>
<file name="components/Home/HomeSuggestedPrompts.tsx">
<violation number="1" location="components/Home/HomeSuggestedPrompts.tsx:23">
P3: If `useCatalogs` hasn't resolved, `catalogsData` is undefined and `catalogName` falls back to an empty string; the UI then shows the same chip label "What's my catalog worth?" but seeds a generic prompt rather than a catalog-anchored prompt. This creates a brief label-to-prompt mismatch if a user clicks before the query resolves. Consider delaying the generic prompt branch until after loading/error is known, or change the chip to a loading/disabled state (or an explicit generic label) while `useCatalogs()` is unresolved so the visible label matches the eventual prompt.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| const HomeCatalogCta = () => { | ||
| const catalogCard = useHomeCatalogCard(); | ||
|
|
||
| if (catalogCard.show) { |
There was a problem hiding this comment.
P2: Claimed-catalog users briefly see—and can click—the marketing valuation CTA on an uncached initial load before useCatalogs() resolves, then it swaps to the catalog card. Represent the catalog-loading state separately and suppress this fallback until the claimed-catalog query has settled.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At components/Home/HomeCatalogCta.tsx, line 17:
<comment>Claimed-catalog users briefly see—and can click—the marketing valuation CTA on an uncached initial load before `useCatalogs()` resolves, then it swaps to the catalog card. Represent the catalog-loading state separately and suppress this fallback until the claimed-catalog query has settled.</comment>
<file context>
@@ -0,0 +1,44 @@
+const HomeCatalogCta = () => {
+ const catalogCard = useHomeCatalogCard();
+
+ if (catalogCard.show) {
+ return (
+ <div className="mb-4 mt-4 text-left text-sm font-normal tracking-normal">
</file context>
| const { selectedArtist } = useArtistProvider(); | ||
| const valuation = useHomeValuation(); | ||
| const tasksState = useHomeTasksModuleState(); | ||
| const { data: catalogsData } = useCatalogs(); |
There was a problem hiding this comment.
P3: If useCatalogs hasn't resolved, catalogsData is undefined and catalogName falls back to an empty string; the UI then shows the same chip label "What's my catalog worth?" but seeds a generic prompt rather than a catalog-anchored prompt. This creates a brief label-to-prompt mismatch if a user clicks before the query resolves. Consider delaying the generic prompt branch until after loading/error is known, or change the chip to a loading/disabled state (or an explicit generic label) while useCatalogs() is unresolved so the visible label matches the eventual prompt.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At components/Home/HomeSuggestedPrompts.tsx, line 23:
<comment>If `useCatalogs` hasn't resolved, `catalogsData` is undefined and `catalogName` falls back to an empty string; the UI then shows the same chip label "What's my catalog worth?" but seeds a generic prompt rather than a catalog-anchored prompt. This creates a brief label-to-prompt mismatch if a user clicks before the query resolves. Consider delaying the generic prompt branch until after loading/error is known, or change the chip to a loading/disabled state (or an explicit generic label) while `useCatalogs()` is unresolved so the visible label matches the eventual prompt.</comment>
<file context>
@@ -19,11 +20,13 @@ const HomeSuggestedPrompts = () => {
const { selectedArtist } = useArtistProvider();
const valuation = useHomeValuation();
const tasksState = useHomeTasksModuleState();
+ const { data: catalogsData } = useCatalogs();
const prompts = getHomeSuggestedPrompts({
</file context>
Chat home for an account that just claimed a catalog said "Ask me about your roster" and linked back to recoupable.dev/valuation - the funnel the signup had completed 60 seconds earlier - with no awareness of the claimed catalog (verified prod 2026-07-20, #1867). (a) Home catalog awareness: when the account has >=1 claimed catalog, the greeting's CTA slot renders a catalog card (name, est. value band + tracks measured when the whole-catalog measurements read is trustworthy) linking to /catalogs/{id}, replacing the circular marketing link. No claimed catalog keeps the current valuation-funnel link, and the chat#1850 valuation hero branch is untouched. (b) In-chat handoff (pragmatic v1): the "What's my catalog worth?" suggested prompt now anchors to the claimed catalog by name and directs the model to start from the songs already in the Recoup catalog, so the ask routes to the existing catalog toolset (select_catalog_songs via the recoup-api MCP) instead of dead-ending on a generic estimate. Free-text routing lives in the api-side system prompt and is out of scope here. New: getHomeCatalogCardState selector (TDD), useHomeCatalogCard composed hook, CatalogCard + HomeCatalogCta components. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
3ea3f78 to
7c0695d
Compare
sweetmantech
changed the title
1 participant
Part of #1867 ("Chat home catalog awareness + in-chat valuation handoff") and #1881 (onboarding v2).
The 2026-07-21 reframe
Original direction (as-built here): add a claimed-catalog card into the chat-first home's greeting CTA slot. The 2026-07-21 decision in #1867 supersedes that framing — the catalog view should be the primary authenticated landing surface, with the persistent nav, rather than a card bolted onto a chat-first home.
The building blocks for that already exist on
main:components/Sidebarwraps every authenticated route viaapp/layout.tsx.app/catalogs(CatalogsPage→CatalogsPageContent) already renders a catalog-first surface inside that nav.So "catalog-is-home" is mostly a landing-surface routing decision (what the authenticated
/renders/redirects to), not net-new UI.What this PR currently contains (transitional foundation, kept non-regressive)
Rather than regress the home back to the circular marketing link while the landing redesign is specced, the rebased commit keeps the catalog-awareness foundation that's correct under either framing:
lib/home/getHomeCatalogCardState.ts— pure selector (TDD): claimed catalog → name + trustworthy value band / measured tracks, degrading to name-only, never back to the marketing link.hooks/useHomeCatalogCard.ts— composed from the same provider-backeduseCatalogs/useCatalogMeasurementshooks the valuation hero uses (react-query dedupes).components/Home/CatalogCard.tsx,components/Home/HomeCatalogCta.tsx— the card + CTA slot (DESIGN.md: shadow-as-border, achromatic chrome).lib/home/getHomeSuggestedPrompts.ts— the "What's my catalog worth?" chip anchors to the claimed catalog by name, routing the ask into the existing catalog toolset.This kills the circular
recoupable.dev/valuationCTA today; the selector/hook are reused by the catalog-is-home landing.TODO — catalog-is-home landing (the reframe's remaining scope)
Deferred out of this PR because it changes the core authenticated product surface and needs design sign-off + roster-gated browser verification:
/behavior for accounts with a claimed catalog: render the catalog view at/(reusingCatalogsPageContent) vs. redirect to/catalogs, keeping the chat reachable. Interacts withHomePage's onboarding-sequence routing and the?q=initial-message path.Verification gate
Full end-to-end verification needs a populated roster/catalog, gated on api item 1b (api#777 — link the searched Spotify artist). The landing-surface change also needs a preview + design review before it merges.
Gates (this rebased revision)
pnpm vitest run lib/home— 41 passing (incl.getHomeCatalogCardState,getHomeSuggestedPrompts).main; base retargeted tomain.🤖 Generated with Claude Code