Skip to content

Update MAP expected values to match map_at_k in notebooks #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miguelgfierro wants to merge 6 commits into
base: staging
Choose a base branch
from
Open

Update MAP expected values to match map_at_k in notebooks #2372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c46a52f
Update sar_single_node smoke MAP expectation for map_at_k
miguelgfierro Sep 4, 2026
32713fa
Update baseline_deep_dive smoke MAP expectation for map_at_k
miguelgfierro Sep 4, 2026
b3add73
Update sar_single_node functional 1m MAP expectation for map_at_k
miguelgfierro Sep 4, 2026
66bd8c7
Update cornac_bivae smoke MAP expectation for map_at_k
miguelgfierro Sep 4, 2026
c066fd2
Update baseline_deep_dive functional 1m MAP expectation for map_at_k
miguelgfierro Sep 4, 2026
7e06853
Update sar_single_node functional 10m MAP expectation for map_at_k
miguelgfierro Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/functional/examples/test_notebooks_python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
(
"1m",
{
"map": 0.060579,
"map": 0.185099,
"ndcg": 0.299245,
"precision": 0.270116,
"recall": 0.104350,
Expand All @@ -26,7 +26,7 @@
(
"10m",
{
"map": 0.098745,
"map": 0.203722,
"ndcg": 0.319625,
"precision": 0.275756,
"recall": 0.154014,
Expand Down Expand Up @@ -57,7 +57,7 @@ def test_sar_single_node_functional(
(
"1m",
{
"map": 0.033914,
"map": 0.139016,
"ndcg": 0.231570,
"precision": 0.211923,
"recall": 0.064663,
Expand Down
2 changes: 1 addition & 1 deletion tests/smoke/examples/test_notebooks_gpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def test_cornac_bivae_smoke(notebooks, output_notebook, kernel_name):
)
results = read_notebook(output_notebook)

assert results["map"] == pytest.approx(0.146552, rel=TOL, abs=ABS_TOL)
assert results["map"] == pytest.approx(0.330255, rel=TOL, abs=ABS_TOL)
assert results["ndcg"] == pytest.approx(0.474124, rel=TOL, abs=ABS_TOL)
assert results["precision"] == pytest.approx(0.412527, rel=TOL, abs=ABS_TOL)
assert results["recall"] == pytest.approx(0.225064, rel=TOL, abs=ABS_TOL)
4 changes: 2 additions & 2 deletions tests/smoke/examples/test_notebooks_python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def test_sar_single_node_smoke(notebooks, output_notebook, kernel_name):
)
results = read_notebook(output_notebook)

assert results["map"] == pytest.approx(0.110591, rel=TOL, abs=ABS_TOL)
assert results["map"] == pytest.approx(0.244722, rel=TOL, abs=ABS_TOL)
assert results["ndcg"] == pytest.approx(0.382461, rel=TOL, abs=ABS_TOL)
assert results["precision"] == pytest.approx(0.330753, rel=TOL, abs=ABS_TOL)
assert results["recall"] == pytest.approx(0.176385, rel=TOL, abs=ABS_TOL)
Expand All @@ -43,7 +43,7 @@ def test_baseline_deep_dive_smoke(notebooks, output_notebook, kernel_name):
assert results["mae"] == pytest.approx(0.846033, rel=TOL, abs=ABS_TOL)
assert results["rsquared"] == pytest.approx(0.136435, rel=TOL, abs=ABS_TOL)
assert results["exp_var"] == pytest.approx(0.136446, rel=TOL, abs=ABS_TOL)
assert results["map"] == pytest.approx(0.052850, rel=TOL, abs=ABS_TOL)
assert results["map"] == pytest.approx(0.138672, rel=TOL, abs=ABS_TOL)
assert results["ndcg"] == pytest.approx(0.248061, rel=TOL, abs=ABS_TOL)
assert results["precision"] == pytest.approx(0.223754, rel=TOL, abs=ABS_TOL)
assert results["recall"] == pytest.approx(0.108826, rel=TOL, abs=ABS_TOL)
Expand Down
Loading