reco-gui: group Calibration/Stitching/Advanced/Lens sliders into labeled cards - #464
Open
RufanMelfor wants to merge 1 commit into
Open
reco-gui: group Calibration/Stitching/Advanced/Lens sliders into labeled cards#464RufanMelfor wants to merge 1 commit into
RufanMelfor wants to merge 1 commit into
Conversation
…led cards Long flat lists of sliders in the right-panel sections read as one undifferentiated column. Adds a small CalGroupBox component (bordered card + small-caps title) and uses it to group related controls: - Calibration: GLOBAL PARAMETERS (Intersect, Camera axis offset, x_ty) - Stitching: SEAM (Seam blend), RIG ALIGNMENT (Rig tilt/roll, Sync offset), FIELD ROI (status + Edit/Paste ROI + JSON paste) - Advanced (auto-calibrate tuning): SAMPLING (Frames, IMU seeds, Skip end), FEATURE DETECTION (AKAZE threshold, Detect Y min/max) - Lens: single LENS PARAMETERS card for the fx/fy/cx/cy/k1-k4 sliders; removed the nested "Fine-tune" sub-header, its content now sits directly under Lens instead of behind an extra collapsible layer Pure layout/grouping change - no bindings, values, or callbacks touched. Not included: a toolbar-level FOV/Reset control and Color Mapping card grouping from the same design pass, both of which build on UI (a preview-overlay FOV badge, the color-matching feature) that doesn't exist on this branch yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CalGroupBoxcomponent (bordered card + small-caps title) and uses it to break up long flat lists of sliders in the right-panel sections into labeled groups:Why
These sections had grown into one undifferentiated column of sliders, making it hard to see at a glance which controls relate to which concern. Grouping them into titled cards (based on a user-provided mockup) makes the panel scannable without changing any behavior.
Not included
A toolbar-level FOV/Reset control and Color Mapping card grouping were part of the same design pass but aren't in this PR - both build on UI that doesn't exist on
mainyet (a preview-overlay FOV badge and the "Debug" button/"Expert Mode" toggle style, and the color-matching feature respectively). Happy to follow up once those land.Test plan
cargo build -p reco-gui- cleancargo fmt --all -- --check- cleancargo test -p reco-gui- 11/11 pass