fix: cross-segment concat seeking + GUI time display after seeks - #445
Merged
Conversation
FFmpeg's concat demuxer reported an unknown duration for chained GoPro/DJI segments when the generated manifest only listed file entries. Seeking past the first segment could then fail or stall even when the underlying filesystem, including NFS, supported normal file seeks. Probe each segment duration while building the concat manifest and emit duration entries when all probes succeed. This gives FFmpeg a usable timeline for cross-segment preview scrubbing without adding filesystem-specific path handling.
Manual movement paths updated only the current-frame property after seek or step operations, so the timeline slider moved while the current-time text stayed stale until playback advanced. Route step forward, step backward, relative seek, and debounced slider seek through sync_frame_display so frame count and time text update together after the new frame is rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes cherry-picked from #329 with authorship preserved (author: @uSpike).
The rest of #329 is not included here.