Confirm before exporting without a field ROI - #430
Open
RufanMelfor wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA. Thank you! |
Start Export now checks the existing has-roi flag and, if no field ROI is set, shows a confirm/cancel dialog instead of silently exporting. AI framing/tracking rely on the ROI to stay on the pitch, so a missing one previously only produced a passive hint text in the calibration panel - easy to miss before kicking off a long export. The confirmation dialog is declared after the Export dialog block so it stacks on top of it (Slint renders siblings in source order) - Start Export is clicked from inside the Export dialog, so the warning must render above it, not underneath.
RufanMelfor
force-pushed
the
feat/export-roi-confirm
branch
from
July 16, 2026 10:38
3c9cc93 to
c2bd80e
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start Export now checks the existing
has-roiflag and, if no field ROIis set, shows a confirm/cancel dialog ("No field ROI set" / "Export
Anyway") instead of silently starting. AI framing/tracking rely on the
ROI to stay on the pitch, so a missing one previously only produced a
passive hint in the calibration panel — easy to miss before kicking off a
long export that then frames poorly for its whole duration.
Pure Slint UI change:
has-roiand its calibration-sync sites alreadyexisted, so no Rust logic changed — confirmed via
git diff origin/main --statshowing onlymain.slinttouched. Mirrors the existingbug-dialog-openmodal pattern (same backdrop/panel/button structure).Verified: build clean,
cargo test -p reco-gui(6/6 passed).