feat(build): Add Intel macOS Make targets for GUI setup and build - #380
Open
vveliev wants to merge 1 commit into
Open
feat(build): Add Intel macOS Make targets for GUI setup and build#380vveliev wants to merge 1 commit into
vveliev wants to merge 1 commit into
Conversation
- Add `make mac-intel-init` to install and pin Rust 1.92.0 toolchain, ffmpeg, pkgconf - Add `make mac-intel-doctor` to verify toolchain, Homebrew, and ffmpeg pkg-config discovery - Add `make gui-build-mac-intel` to compile reco-gui without default ORT backend (resolves prebuilt availability issues on x86_64-apple-darwin) - Add `make gui-run-mac-intel` convenience target to run the built GUI binary - Update README.md with Intel macOS setup section and usage examples - Makefile handles rustup installation via Homebrew and detects pkg-config paths automatically - All targets verified working on Intel Mac with Rust 1.92.0
|
Thank you for your contribution. Before this can be merged, please read our Contributor License Agreement and sign it by posting the comment below. It grants the maintainer the right to relicense your contribution, including under a commercial license for dual-licensing. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds Intel (x86_64) macOS bootstrap/build instructions and a Makefile to standardize GUI builds without default ORT features.
Changes:
- Document Intel Mac setup + GUI build/run workflow via Make targets.
- Add root
Makefilewithmac-intel-*andgui-*-mac-inteltargets. - Add “doctor” target to validate toolchain and FFmpeg/pkg-config availability.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| README.md | Adds Intel Mac setup section and Make-based build/run instructions. |
| Makefile | Introduces macOS Intel dependency bootstrap, diagnostics, and build/run targets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+15
to
+26
| brew install ffmpeg pkgconf rustup-init | ||
| @RUSTUP_BIN="$$(command -v rustup 2>/dev/null || true)"; \ | ||
| if [ -z "$$RUSTUP_BIN" ] && [ -x "$$(brew --prefix rustup)/bin/rustup" ]; then \ | ||
| RUSTUP_BIN="$$(brew --prefix rustup)/bin/rustup"; \ | ||
| fi; \ | ||
| if [ -z "$$RUSTUP_BIN" ] && [ -x "$$HOME/.cargo/bin/rustup" ]; then \ | ||
| RUSTUP_BIN="$$HOME/.cargo/bin/rustup"; \ | ||
| fi; \ | ||
| if [ -z "$$RUSTUP_BIN" ]; then \ | ||
| echo "rustup is not available in PATH. Add $$(brew --prefix rustup)/bin to PATH and retry."; \ | ||
| exit 1; \ | ||
| fi; \ |
|
|
||
| mac-intel-init: | ||
| @command -v brew >/dev/null || { echo "Homebrew is required: https://brew.sh"; exit 1; } | ||
| brew update |
Comment on lines
+16
to
+26
| @RUSTUP_BIN="$$(command -v rustup 2>/dev/null || true)"; \ | ||
| if [ -z "$$RUSTUP_BIN" ] && [ -x "$$(brew --prefix rustup)/bin/rustup" ]; then \ | ||
| RUSTUP_BIN="$$(brew --prefix rustup)/bin/rustup"; \ | ||
| fi; \ | ||
| if [ -z "$$RUSTUP_BIN" ] && [ -x "$$HOME/.cargo/bin/rustup" ]; then \ | ||
| RUSTUP_BIN="$$HOME/.cargo/bin/rustup"; \ | ||
| fi; \ | ||
| if [ -z "$$RUSTUP_BIN" ]; then \ | ||
| echo "rustup is not available in PATH. Add $$(brew --prefix rustup)/bin to PATH and retry."; \ | ||
| exit 1; \ | ||
| fi; \ |
Comment on lines
+53
to
+63
| @RUSTUP_BIN="$$(command -v rustup 2>/dev/null || true)"; \ | ||
| if [ -z "$$RUSTUP_BIN" ] && [ -x "$$(brew --prefix rustup)/bin/rustup" ]; then \ | ||
| RUSTUP_BIN="$$(brew --prefix rustup)/bin/rustup"; \ | ||
| fi; \ | ||
| if [ -z "$$RUSTUP_BIN" ] && [ -x "$$HOME/.cargo/bin/rustup" ]; then \ | ||
| RUSTUP_BIN="$$HOME/.cargo/bin/rustup"; \ | ||
| fi; \ | ||
| if [ -z "$$RUSTUP_BIN" ]; then \ | ||
| echo "rustup is required (brew install rustup-init)."; \ | ||
| exit 1; \ | ||
| fi; \ |
Comment on lines
+126
to
+127
| # Verify ffmpeg/pkg-config and Rust are visible | ||
| make mac-intel-doctor |
| @@ -0,0 +1,68 @@ | |||
| SHELL := /bin/zsh | |||
Contributor
|
Hello; Could you please sign the CLA so I could merge it? Have you been able to get the AI to work on MacOS intel? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make mac-intel-initto install and pin Rust 1.92.0 toolchain, ffmpeg, pkgconfmake mac-intel-doctorto verify toolchain, Homebrew, and ffmpeg pkg-config discoverymake gui-build-mac-intelto compile reco-gui without default ORT backend (resolves prebuilt availability issues on x86_64-apple-darwin)make gui-run-mac-intelconvenience target to run the built GUI binaryDescription
Checklist
cargo test --allpassescargo clippy --all-targets -- -D warningsandcargo fmt --all -- --checkpassScreenshots