Add full IP chain for getting real IP of user in the element UI. - #24
Merged
realtyem merged 7 commits intoFeb 14, 2026
Merged
Conversation
added 6 commits
February 3, 2026 13:18
Owner
|
Not completely sure why the worker's mode tests failed yet; I retriggered them to run again. If they fail again I'll investigate more I'm onboard with the header adjustment, that looks like what I thought it was supposed to be doing. The |
Contributor
Author
|
I can remove it here and just set the nginx opts. I used the synapse_version arg in docker compose to locally build against specific version of synapse with the nginx fixes. |
Contributor
Author
|
Removed the SYNAPSE_VERSION. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, haven't done a PR in a while. I've noticed that the IP users see in element does not match their computer IP.
https://paigekim29.medium.com/understanding-x-forwarded-for-header-settings-in-nginx-4929f49d57dd
Instead of using $remote_addr which is the last known address, which might usually be from a proxy, I changed it to use the full chain instead.
I also added the option to use the synapse version that is defined in the arg SYNAPSE_VERSION