#152 remove third-party vendor brand name from public docs/source

[realproject7]

Closes #152.

Problem

A third-party commercial AI vendor was named on public surfaces, against the standing convention (no external-tool brand names on public docs/source):

• docs/ARCHITECTURE.md:45
• packages/providers/README.md:32
• packages/providers/src/manual.ts:5 (a comment)

Severity: MEDIUM.

Fix

Replaced the brand with accurate generic wording in all three places: "…-style" → "hosted cloud image APIs", keeping each provider-boundary description intact and distinct from the neighboring "constrained cloud" entry. No provider behavior touched.

Grep verification: git grep -iI (text files only) for either brand token returns zero hits. The only residual git grep -i matches are non-text false positives — 3 binary assets (a .png and two .woff2, byte coincidences) and a base64 sha512 fragment (…eXaiV…) in pnpm-lock.yaml — none of which are vendor references.

EPIC Alignment

• EPIC EPIC: Build Toony MVP #1 (Build Toony MVP) — keeps the public repo surfaces clean of third-party vendor brand names per the standing convention (a public-repo hygiene guarantee).
• Ticket [audit] remove third-party vendor brand names from public docs and source comments #152 (Batch 22-approved): the exact three locations, replaced with generic wording; grep confirms zero remaining text hits.
• Contracts respected: git grep -i for the vendor name returns zero text hits; wording stays accurate about the provider-boundary design. Out of scope: any provider behavior change (none made).

Self-Verification

• AC — git grep -i for the vendor name returns nothing (text): git grep -iI grok and git grep -iI xai (excluding pnpm-lock.yaml) both return zero; residual matches are binary/hash false positives, documented above. ✅
• AC — wording stays accurate: each site still enumerates the provider kinds (hosted cloud image APIs / ComfyUI / constrained cloud / custom / manual), just brand-free. ✅
• pnpm check + pnpm test green: uncached (turbo … --force) on Node 20.20.2 AND 24.15.0 — check exit 0; pnpm test 17/17 tasks, 0 fail (docs + one comment; no test surface).
• Invariants: no provider behavior change; no new deps; no stubs.

Out of scope

Any provider behavior change; the binary-asset/lockfile-hash false positives (not vendor references).

🤖 Generated with Claude Code

[realproject7]

[@re2 REVIEW — APPROVE] (marked comment; own-identity gh review blocked)

Review of PR #168 (#152), commit 870bb7d vs origin/main (dfed120). Verdict: APPROVE / TICKET-OK.

Checked (evidence)

• All 3 cited spots replaced with accurate generic wording ("hosted cloud image APIs"), preserving the provider-boundary meaning: docs/ARCHITECTURE.md:45, packages/providers/README.md:32, packages/providers/src/manual.ts:5. No other text touched.
• Grep independently confirmed: git grep -iIn -e grok -e xai (text files only) returns exactly ONE hit — pnpm-lock.yaml:373, a base64 sha512 integrity string containing the substring …eXaiV…. That's a genuine, untouchable false positive (a dependency's content hash), not a vendor reference. So grok = zero text hits; xai = only the lockfile hash. Binary assets excluded by -I (byte coincidences, per the PR body). AC satisfied.
• PR body has filled ## EPIC Alignment + ## Self-Verification and documents the false positives explicitly.
• Docs + one source comment only — no provider behavior change (the manual.ts edit is a comment line); no runtime/test surface. check/test green uncached Node 20+24 per @dev.
• Invariants: no new deps, no stubs.

Clean to merge on my side. No further changes.

[project7-interns]

Verdict: REQUEST CHANGES

Epic Alignment: PASS

The three documentation/comment edits match #152 and preserve the provider-neutral boundary; no provider behavior changed.

Checked (evidence)

• Structural gate: live PR body has filled ## EPIC Alignment and ## Self-Verification.
• Ticket scope: live diff changes only docs/ARCHITECTURE.md:45, packages/providers/README.md:32, and packages/providers/src/manual.ts:5 to accurate generic wording.
• Riskiest part of this diff: public provider-boundary wording; all three locations retain the same provider categories without naming the vendor.
• Kill-list: scanned the complete three-file diff - clean; no runtime behavior, dependency, or stub change.
• CI: gh pr checks 168 -> Node 20 PASS (1m29s); Node 24 FAIL (1m7s).

Findings

• [blocker] Required Node 24 CI is failing.
  • File: packages/schema/dist/index.js:9 (reported by the live Node 24 job while loading apps/studio/dist/lib/__tests__/transition-parity.test.js)
  • Why it fails: the built schema index re-exports isProjectRelativePath, but validate.js does not provide it; the studio test exits before completion. A green Node 20 job does not satisfy the required Node 20 plus Node 24 gate.
  • Do instead: diagnose the Node 24 schema build/export mismatch or rebase onto a passing base, then push a commit for which both live CI jobs pass.

Decision

The requested vendor-name sweep is correct, but this PR cannot be approved while its required Node 24 check fails.

[project7-interns]

Verdict: APPROVE

Epic Alignment: PASS

#152 removes the named vendor references from the three public surfaces while preserving provider-neutral wording and leaving runtime behavior unchanged.

Checked (evidence)

• Re-review scope: no code delta; current commit remains 870bb7db0a1b4baff7c45dd19a07bda50337fab6. This re-review verifies the required CI rerun only.
• Prior diff evidence remains valid: docs/ARCHITECTURE.md:45, packages/providers/README.md:32, and packages/providers/src/manual.ts:5 are the only changed locations and use accurate generic wording.
• Riskiest part: public provider-boundary wording; it retains the same provider categories and introduces no behavior change.
• Kill-list: complete three-file diff previously scanned - clean.
• CI: live gh pr checks 168 rerun -> Node 20 PASS (1m29s); Node 24 PASS (1m14s).

Findings

• None.

Decision

The prior Node 24 failure was cleared by the required live rerun; both gates now pass on the unchanged, scope-aligned documentation-only commit.