[#1005] docs(install-mac): Update macOS installation for the current QuadWork release#1013
Conversation
Reconcile docs/install-mac.md with the current CLI, SetupWizard, README, and package metadata (v2.7.0), removing stale v1.14.5-era wording. - Verify step: `quadwork --version` is not a subcommand (falls through to the usage help); use `npm list -g quadwork`, and bump the example version from 1.14.5 to 2.7.0 (package.json). - Dashboard URL: server binds 127.0.0.1 (server/index.js:270) and the CLI auto-opens http://127.0.0.1:${port} (bin/quadwork.js:928) — corrected from localhost and the unverified stdout example; noted auto-open behavior. - First-run setup: describe the Agent Models step — per-role CLI backend (Claude Code / Codex / Gemini CLI) plus optional per-role model selection (src/lib/agentModels.ts, SetupWizard BACKENDS); seed files are AGENTS.md and CLAUDE.md per worktree. - Trust prompt: drop the stale "v1.14.5+ pre-trusts" claim and the removed `claude -p "echo ok"` manual workaround (#975 dropped synchronous pre-trust); describe the current onData trust-listener that auto-answers the prompt (server/index.js:1182). Docs-only; no runtime code, package versions, tests, or other docs touched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Epic Alignment: FAIL
#1005 requires every command and prerequisite claim to be verified against current sources; the PR's verification evidence misidentifies a source location.
Checked (evidence)
- Scope: live
gh pr diff 1013→ onlydocs/install-mac.md. - Installation/model/trust content: current head confirms package version 2.7.0, CLI dispatch, model catalog, and trust listener.
- Riskiest part of this diff: lifecycle/network guidance; its body evidence is incorrect as detailed below.
- Kill-list: scanned all new diff ranges — documentation-evidence hit listed in Findings.
- CI:
gh pr checks 1013→test pass(50s).
Findings
- [blocking] Dashboard-bind citation is incorrect.
- File:
server/index.js:270 - Why it fails: The PR's
## Self-Verificationcites this as the dashboard loopback bind, but it is only thecheckPortprobe. The documentation claim is supported by the actual server listener atserver/index.js:2324; #1005 requires honest, source-verified guidance. - Do instead: Change the PR body's loopback-bind citation from
server/index.js:270toserver/index.js:2324, then request re-review. No documentation diff is required for this correction.
- File:
Decision
The guide’s changed prose otherwise matches the current implementation, but the required verification record is inaccurate and must be corrected before approval.
@re2 Independent Review — APPROVE ✅ (head
|
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Epic Alignment: PASS
The unchanged one-file guide remains aligned with #1005; the corrected verification record now accurately supports its loopback lifecycle guidance.
Checked (evidence)
- Re-review scope: same current head
6a44dc5; only the PR body changed after my review. - Prior finding resolved: PR
## Changesand## Self-Verificationnow citeserver/index.js:2324, the actualserver.listen(PORT, "127.0.0.1", …)listener, instead of thecheckPortprobe at:270. - No diff re-review required: live PR remains
docs/install-mac.mdonly; prior command, model, worktree, bridge, and trust-listener checks stand. - Riskiest part of this diff: loopback dashboard guidance; its code citation now matches the running server implementation.
- Kill-list: no new ranges since my last review — clean.
- CI:
gh pr checks 1013→test pass(50s).
Findings
- None.
Decision
The sole blocking evidence error is corrected without a code change; the current head satisfies #1005 and has a passing live check.
@re2 Corrected Verdict — APPROVE ✅ (head
|
Closes #1005
Summary
Docs-only. Reconciles
docs/install-mac.mdwith the current CLI, SetupWizard, README, and package metadata (v2.7.0), removing stale v1.14.5-era wording and correcting commands that no longer match the code. Scope:docs/install-mac.mdonly.Changes
quadwork --versionis not a real subcommand — it falls through to the usage help (bin/quadwork.jsdispatch: init/start/stop/add-project/cleanup/doctor/migrate-agent-slugs/ac-restore, else usage). Replaced withnpm list -g quadwork, and updated the example version 1.14.5 → 2.7.0 (package.json).server/index.js:2324→server.listen(PORT, "127.0.0.1"), loggingQuadWork server listening on http://127.0.0.1:${PORT}) and the CLI auto-openshttp://127.0.0.1:${port}(bin/quadwork.js:928). Correctedlocalhost→127.0.0.1, dropped the unverifiedQuadWork dashboard: …stdout example, and documented the auto-open behavior.SetupWizard.tsx:188-192) plus optional per-role model selection (src/lib/agentModels.ts— Claudeopus/sonnet/…, Codexgpt-5.4/gpt-5.6-*, Geminigemini-2.5-pro/-flash,(CLI default)). Corrected the seed-files note toAGENTS.mdandCLAUDE.mdper worktree (SetupWizard.tsx:81).claude -p "echo ok"manual workaround — [#S9] De-block the event loop (file-chat busy-wait, butler/setup execFileSync) #975 dropped that synchronous pre-trust. Described the current behavior: anonDatatrust-listener on each agent PTY auto-answers the prompt at startup (server/index.js:1114-1119,:1182).EPIC Alignment
docs/install-mac.md. This diff touches exactly that file.Self-Verification
package.json→name: quadwork,version: 2.7.0,engines: {node: ">=20"}.bin/quadwork.js:1352-1400— no--version; unknown args print usage.init/start/stopall present and used as documented.server/index.js:2324;bin/quadwork.js:928(dashboardUrl = http://127.0.0.1:${port}).bin/quadwork.js:253,864,911,947;server/index.js:311— unchanged doc claims re-confirmed accurate.src/components/SetupWizard.tsx:188-192,src/lib/agentModels.ts:10-45.server/index.js:1114-1119(old pre-trust dropped),:1182-1185(auto-answer within first ~10s).bin/quadwork.js:630-631—project-head/,project-re1/,project-re2/,project-dev/.rg -n "1\.14|localhost|claude -p|quadwork --version" docs/install-mac.md→ only the legitimatenode/git/gh --versionprereq lines remain.git diff --stat→docs/install-mac.mdonly.Acceptance criteria