[#1237] Strip v1 airdrop logic (points, award, cron, checkin)#1274
Merged
Conversation
…checkin v5 finalize SQL assumes pl_points buy rows = raw PLOT spent. Strip streak boost from computeBuyPoints, delete computeReferralPoints, no-op awardWritePoints/awardRatePoints, remove referral + streak fetches from cron handler, and return 410 Gone from checkin endpoint. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
realproject7
commented
May 26, 2026
realproject7
left a comment
Owner
Author
There was a problem hiding this comment.
@re2 review — APPROVE ✅
Checked against issue #1237 acceptance criteria:
| Criterion | Status |
|---|---|
computeBuyPoints(100, 5) === 100 (no streak multiplication) |
✅ returns raw plotSpent |
computeReferralPoints deleted |
✅ |
awardWritePoints + awardRatePoints return early, no DB writes |
✅ no-op with return; |
Cron writes only action='buy' rows (no referral inserts) |
✅ referral block + streak/referral fetches removed |
/api/airdrop/checkin returns 410 Gone |
✅ |
| No regressions in buy flow | ✅ cron still processes buys correctly |
| Version bump 1.30.0 → 1.30.1 (patch) | ✅ |
Code review notes:
- Cron handler correctly simplified: removed 4 Supabase queries (streak lookups for buyers/referrers, referral map, referrer streak map) — only dedup query remains
computeBuyPointskeeps_currentStreakparam for API compat per spec — callers don't need signature changes- Award functions keep signatures with
_-prefixed params — safe for existing callers getStreakBoostre-export frompoints.tspreserved (may be used elsewhere)- Net -333 lines, no logic additions beyond the no-ops
No issues found.
project7-interns
approved these changes
May 26, 2026
project7-interns
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR matches #1237: buy points are raw PLOT spent, referral point computation is removed, write/rate awards are no-ops, the cron no longer fetches streak/referral data or writes referral rows, and the check-in endpoint returns 410 Gone. The existing caller signatures are preserved for compatibility.
Findings
- No blocking findings.
Decision
Approve. lint-and-typecheck is passing; e2e was still pending at review time, so merge should still wait for required CI to complete successfully.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
computeBuyPointsnow returns rawplotSpent(no streak multiplication) — param kept for API compatcomputeReferralPointsdeleted — v5 handles referrals via multiplier at finalizeawardWritePoints+awardRatePoints→ no-op (return early, no DB writes)action='buy'rows/api/airdrop/checkin→ returns410 GoneWhy
v5 finalize SQL assumes
pl_points.action='buy'.points= raw PLOT spent. Streak-boosted values would cause incorrect distribution.Version
1.30.0 → 1.30.1
🤖 Generated with Claude Code