Skip to content

Viewer fixes from the Stage 1 review: finding counts, connection hover, direct-only node hover - #14

Merged
realmyang merged 1 commit into
mainfrom
viewer-finding-counts-edge-hover
Sep 29, 2026
Merged

realmyang merged 1 commit into
mainfrom
viewer-finding-counts-edge-hover

Conversation

@realmyang

Copy link
Copy Markdown
Owner

Viewer fixes the owner asked for while reviewing the Stage 1 pilot diagrams in VS Code. This PR holds no pilot records, so any merge method is fine.

What changes

  • Finding counts agree. Phase and group badges and Outline rows count each finding once, so they match the toolbar and status bar. Before, one finding that named three steps and two connections showed 5. A collapsed group also counts the findings of the connections it hides.
  • Connection hover lists findings. Hovering a connection, or the severity marker on it, lists that connection's findings in the hover card, just as hovering a step does. The whole marker opens the card at any zoom, the card sits above the marker, and the connection's Inspector lists the findings too. A group's card lists the same findings its badge counts.
  • Node hover is direct only. Hovering a step or group lights and animates only its direct connections. Focus mode (select, then F) still lights the full upstream and downstream lineage, and the shortcut sheet now says so.
  • Related fixes found in review:
    • A trunk that a hover or focus mode opened now folds again when it ends. It used to stay open, which also happened before this PR.
    • Cards a hover dims stay clickable; only focus mode makes them inert.
    • Turning focus mode off with the pointer on a card brings back that card's hover.
    • The too-many-connections message for a hover now suggests hovering a single connection.

webview/src changes are rebuilt into webview/dist/ and vscode-extension/media/. The CHANGELOG has an Unreleased section, and docs/STATUS.md has a paragraph. The version is unchanged. docs/FEATURES_FLOW_AND_SCOPE.md still describes the lineage hover, but it has the historical-record banner, so it is left as written.

Checks run locally

Node v26.4.0, Python 3.13.15

  • sh scripts/e2e.sh --skip-npm-install: E2E OK: 15 exercised gates
    • pytest: 915 passed
    • webview: 122/122
    • extension: 266/266

These are jsdom and unit tests only. The viewer has not been re-checked in live VS Code.

🤖 Generated with Claude Code

…r, direct-only node hover

The owner reported two defects while reading pilot diagrams in VS Code and
asked for a narrower node hover:

- Phase and group badges and Outline rows count each finding once, so they
  agree with the toolbar and status bar; a collapsed group also counts the
  findings of the connections it hides.
- Hovering a connection or its severity marker lists the connection's
  findings in the hover card; the whole marker opens it at any zoom, and the
  connection Inspector lists the findings too. A group's card lists the
  findings its badge counts.
- Hovering a card lights and animates only its direct connections; focus
  mode (F) keeps the full lineage. Trunks a hover or focus mode opened fold
  again when it ends, cards a hover dims stay clickable, and turning focus
  mode off under the pointer restores the hover.

Checked by local jsdom tests (webview 122, extension 266) and
scripts/e2e.sh; not yet checked in live VS Code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant