Overhaul rust library to use cmake + cxx, remove old api system#57
Merged
Conversation
Coverage ReportNo coverage data available. |
|
aliceagain
approved these changes
Sep 30, 2025
aliceagain
left a comment
aliceagain
left a comment
Member
There was a problem hiding this comment.
looks good to me! very cool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting hook up the
cxxcrate as a simpler way for us to bridge logic between rust and libmahjong! It does a bunch of heavy macro work to let us bring over shared logic on a class by class basis very nicely. To start with the process, this PR brings over winds and pieces, and gets some test coverage on them!I've also removed the C API library in this PR, as this will replace it. Additionally, I had to do some additional tinkering to the nix flake to get the dev shell working, I hope I didn't break anything (we'll find out)